Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refine supplier scorecard standings. #36414

Merged
merged 2 commits into from
Aug 5, 2023
Merged

fix: Refine supplier scorecard standings. #36414

merged 2 commits into from
Aug 5, 2023

Conversation

bosue
Copy link
Contributor

@bosue bosue commented Jul 30, 2023

Very minor, per #36269.

IMG_1252

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 30, 2023
@bosue bosue marked this pull request as draft July 31, 2023 12:11
@codecov
Copy link

codecov bot commented Jul 31, 2023 •
edited
Loading

Codecov Report

Merging #36414 (79fd0e4) into develop (11bd15e) will decrease coverage by 0.01%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #36414      +/-   ##
===========================================
- Coverage    64.53%   64.53%   -0.01%     
===========================================
  Files          786      786              
  Lines        61123    61123              
===========================================
- Hits         39446    39443       -3     
- Misses       21677    21680       +3
Files Changed Coverage Δ
...g/doctype/supplier_scorecard/supplier_scorecard.py 55.97% <ø> (ø)

... and 3 files with indirect coverage changes

@bosue bosue force-pushed the Refine_Supplier_Scorecards branch from 01a9b7e to 670929a Compare July 31, 2023 21:38
@bosue bosue marked this pull request as ready for review July 31, 2023 21:38
@bosue bosue changed the title Refine supplier scorecard standings. fix: Refine supplier scorecard standings. Jul 31, 2023
@bosue bosue force-pushed the Refine_Supplier_Scorecards branch from 670929a to f785f47 Compare July 31, 2023 21:40
@deepeshgarg007 deepeshgarg007 merged commit 5435c64 into frappe:develop Aug 5, 2023
@bosue bosue mentioned this pull request Aug 5, 2023
Closed
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bosue @deepeshgarg007