Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Job Card validation fixed when displaying total completed quantity #36375

Merged
merged 1 commit into from
Jul 29, 2023
Merged

fix: Job Card validation fixed when displaying total completed quantity #36375

merged 1 commit into from
Jul 29, 2023

Conversation

ramonus
Copy link

@ramonus ramonus commented Jul 28, 2023

When job card total completed qty does not match the for quantity it shows an error with the two values but, the variable that should be the total completed qty is substituted by a string and always returns 0.0 from the flt function.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #36375 (49981fe) into develop (dac9fd6) will increase coverage by 0.00%.
Report is 3 commits behind head on develop.
The diff coverage is 50.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #36375   +/-   ##
========================================
  Coverage    64.25%   64.25%           
========================================
  Files          785      785           
  Lines        60965    60965           
========================================
+ Hits         39173    39174    +1     
+ Misses       21792    21791    -1     
Files Changed Coverage Δ
erpnext/hooks.py 100.00% <ø> (ø)
erpnext/manufacturing/doctype/job_card/job_card.py 72.84% <0.00%> (ø)
erpnext/accounts/utils.py 73.44% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@s-aga-r s-aga-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramonus please add the before and after screenshots.

@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Jul 28, 2023
@rohitwaghchaure rohitwaghchaure merged commit b71dafd into frappe:develop Jul 29, 2023
rohitwaghchaure added a commit that referenced this pull request Jul 29, 2023
…-36375

fix: Job Card validation fixed when displaying total completed quantity (backport #36375)
@ankush
Copy link
Member

ankush commented Jul 31, 2023

@s-aga-r we can skip screenshots in trivial fixes like these. Description seems enough.

@ramonus ramonus deleted the job-card-fix branch September 29, 2023 09:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants