fix: set new purchase_receipt_amount on asset split #36272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mergify copy develop |
✅ Pull request copies have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
(cherry picked from commit e867fe7) # Conflicts: # erpnext/assets/doctype/asset/asset.py
anandbaburajan
added a commit
that referenced
this pull request
Jul 24, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jul 26, 2023
# [14.32.0](v14.31.3...v14.32.0) (2023-07-26) ### Bug Fixes * added missing option Partially Received in the status dropdown field ([4fa93b0](4fa93b0)) * allocation logic on 'Get Outstanding Invoices' btn in PE ([14600fa](14600fa)) * allow both custodian and location while creating asset ([#36263](#36263)) ([2b47f58](2b47f58)) * Ambiguous column error while submitting stock entry (backport [#36209](#36209)) ([#36222](#36222)) ([844ec58](844ec58)) * apply discount on item after applying price list ([#36316](#36316)) ([cff6e72](cff6e72)) * apply terms validaton only in Sales/Purchase documents ([8f24292](8f24292)) * broken overallocation validation in payment entry ([e1d31aa](e1d31aa)) * clear accounting dimension value when based on field changes ([1fe6d4e](1fe6d4e)) * customer filter in process soa ([5938af9](5938af9)) * Default fiscal year in accounting, buying and sellingcharts ([8ca3d6b](8ca3d6b)) * fetch acc dimension fieldname ([542c804](542c804)) * FY in naming series variable for orders ([6a6a3ae](6a6a3ae)) * group by in fixed asset register ([#36310](#36310)) ([6cca18e](6cca18e)) * Ignore permissions while submitting account closing balance record ([#35536](#35536)) ([c2976ef](c2976ef)) * itemised tax breakup ([6f2e639](6f2e639)) * made item or warehouse filter mandatory (backport [#36208](#36208)) ([#36215](#36215)) ([57cf3c2](57cf3c2)) * no default email account causing reposting issue ([026f9f5](026f9f5)) * **regional:** set `frappe.flags.company` temporarily, where required ([73e9b38](73e9b38)) * set new purchase_receipt_amount on asset split ([#36272](#36272)) ([e867fe7](e867fe7)) * timeout error while cancelling the Purchase Receipt ([0575005](0575005)) * Trial Balance report considering cancelled entries ([ca4f86d](ca4f86d)) ### Features * filter based on accounting dimension in profitability analysis ([ba95df2](ba95df2))
|
🎉 This PR is included in version 14.32.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an asset with a purchase receipt was split, a
Gross Purchase Amount should be equal to purchase amount of one single Asseterror was thrown since thepurchase_receipt_amountfor the new asset wasn't updated. So fixed that.