Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: apply terms based validation only on sales/purchase doctypes #36261

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jul 24, 2023

Apply Payment Terms based allocation validation on Sales/Puchase Invoice and Orders.
continues: #36241

This has been directly added in the v14 backport: #36252

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 24, 2023
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #36261 (3dd119e) into develop (efb5152) will increase coverage by 0.00%.
The diff coverage is 60.77%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #36261   +/-   ##
========================================
  Coverage    64.14%   64.14%           
========================================
  Files          784      784           
  Lines        60731    60730    -1     
========================================
  Hits         38956    38956           
+ Misses       21775    21774    -1     
Impacted Files Coverage Δ
erpnext/accounts/report/financial_statements.py 31.07% <ø> (ø)
...ext/accounts/report/trial_balance/trial_balance.py 0.00% <0.00%> (ø)
...eport/address_and_contacts/address_and_contacts.py 0.00% <ø> (ø)
...t/setup/doctype/global_defaults/global_defaults.py 96.87% <ø> (ø)
.../setup/setup_wizard/operations/install_fixtures.py 90.75% <ø> (ø)
erpnext/stock/doctype/stock_entry/stock_entry.py 82.17% <ø> (ø)
...rial_and_batch_summary/serial_and_batch_summary.py 0.00% <0.00%> (ø)
erpnext/telephony/doctype/call_log/call_log.py 37.62% <6.66%> (ø)
...ctype/accounting_dimension/accounting_dimension.py 63.97% <25.00%> (ø)
erpnext/accounts/utils.py 73.44% <25.00%> (ø)
... and 21 more

... and 1 file with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 4464b2a into frappe:develop Jul 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant