Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow manual asset receipt mov from nowhere #36093

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix: allow manual asset receipt mov from nowhere #36093

merged 1 commit into from
Jul 11, 2023

Conversation

anandbaburajan
Copy link
Contributor

If the first automatic receipt asset movement created on submission of an asset is cancelled for some reason, the asset is left without a location. In that case, it's helpful to allow the user to manually do the receipt asset movement.

@anandbaburajan anandbaburajan added backport version-13-hotfix backport develop instructs mergify to frontport PR to develop branch labels Jul 11, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jul 11, 2023
@anandbaburajan anandbaburajan merged commit 4aaa1a1 into frappe:version-14-hotfix Jul 11, 2023
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
mergify bot pushed a commit that referenced this pull request Jul 11, 2023
(cherry picked from commit 4aaa1a1)

# Conflicts:
#	erpnext/assets/doctype/asset_movement/asset_movement.py
anandbaburajan added a commit that referenced this pull request Jul 12, 2023
…36094)

fix: allow manual asset receipt mov from nowhere (#36093)

(cherry picked from commit 4aaa1a1)

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
anandbaburajan added a commit that referenced this pull request Jul 12, 2023
…36095)

* fix: allow manual asset receipt mov from nowhere (#36093)

(cherry picked from commit 4aaa1a1)

# Conflicts:
#	erpnext/assets/doctype/asset_movement/asset_movement.py

* chore: fix conflict

---------

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jul 18, 2023
## [13.52.6](v13.52.5...v13.52.6) (2023-07-18)

### Bug Fixes

* allow manual asset receipt mov from nowhere (backport [#36093](#36093)) ([#36095](#36095)) ([2993eb5](2993eb5))
* HSN code not showing up in GST itemised register reports ([#36142](#36142)) ([1d3917b](1d3917b))
* improve "Update Items" modal ([#36105](#36105)) ([3bc899f](3bc899f))

### Performance Improvements

* index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36145](#36145)) ([120de24](120de24))
frappe-pr-bot pushed a commit that referenced this pull request Jul 18, 2023
# [14.31.0](v14.30.7...v14.31.0) (2023-07-18)

### Bug Fixes

* `TypeError` while creating WO from PP (backport [#36136](#36136)) ([#36137](#36137)) ([dd51010](dd51010))
* Account balance patch and query fixes ([#36117](#36117)) ([0147754](0147754))
* Accounts closing balance patch ([#36113](#36113)) ([cf29156](cf29156))
* allow manual asset receipt mov from nowhere ([#36093](#36093)) ([4aaa1a1](4aaa1a1))
* Ambiguous column error while submitting stock entry ([#36058](#36058)) ([a3a052b](a3a052b))
* circular dependency during reposting causing timeout error ([2c21404](2c21404))
* get_dimension with_cost_center_and_project=false is not working ([#35974](#35974)) ([42c93a1](42c93a1))
* Handle multi-company in patch ([#36127](#36127)) ([e7f5754](e7f5754))
* improve "Update Items" modal ([#36105](#36105)) ([b86571d](b86571d))
* incorrect Balance Qty in the stock ledger for the item with Serial and Batch no ([373b868](373b868))
* incorrect Reserved Qty for Production Plan in BIN for multi-uom case ([2f632d0](2f632d0))
* Opening balance in TB report ([#36171](#36171)) ([313ad7a](313ad7a))
* Opening entries showing up incorrectly in TB report ([#36135](#36135)) ([d10e5e6](d10e5e6))
* Remove current fiscal year from Global Defaults ([#35960](#35960)) ([b877fa6](b877fa6))
* Trailing opening entries in Accounts closing balance ([#36175](#36175)) ([8a607db](8a607db))
* validate docs in closed accounting period on save ([#36157](#36157)) ([5985e02](5985e02))

### Features

* add local holidays ([#36116](#36116)) ([94caf7f](94caf7f))
* add project filter in reports importing financial statements js file ([#36097](#36097)) ([63e26e3](63e26e3))

### Performance Improvements

* index in `Item` and `Item Variant Attribute` (backport [#36133](#36133)) ([#36144](#36144)) ([6198983](6198983))
* send SLA doctypes in boot ([adb6918](adb6918))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport develop instructs mergify to frontport PR to develop branch backport version-13-hotfix needs-tests This PR needs automated unit-tests. released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants