Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: accepted warehouse and rejected warehouse can't be same #36001

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: accepted warehouse and rejected warehouse can't be same #36001

merged 1 commit into from
Jul 10, 2023

Conversation

rohitwaghchaure
Copy link
Collaborator

Added validation

Screenshot 2023-07-04 at 5 27 52 PM

@github-actions github-actions bot added the buying label Jul 4, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #36001 (9d466c4) into develop (8179d6a) will increase coverage by 0.00%.
The diff coverage is 55.55%.

❗ Current head 9d466c4 differs from pull request most recent head d618aae. Consider uploading reports for the commit d618aae to get more accurate results

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #36001   +/-   ##
========================================
  Coverage    64.22%   64.23%           
========================================
  Files          785      785           
  Lines        60644    60644           
========================================
+ Hits         38948    38952    +4     
+ Misses       21696    21692    -4
Impacted Files Coverage Δ
erpnext/setup/install.py 23.00% <ø> (ø)
erpnext/controllers/buying_controller.py 84.51% <55.55%> (-0.09%) ⬇️

... and 5 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-added-validation-for-rejected-warerhouse branch 2 times, most recently from 9d466c4 to b3b5fdd Compare July 6, 2023 13:15
@barredterra barredterra mentioned this pull request Jul 6, 2023
Merged
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-added-validation-for-rejected-warerhouse branch from b3b5fdd to d618aae Compare July 10, 2023 07:50
@rohitwaghchaure rohitwaghchaure merged commit 22eee47 into frappe:develop Jul 10, 2023
@mergify mergify bot mentioned this pull request Jul 10, 2023
Merged
rohitwaghchaure added a commit that referenced this pull request Jul 10, 2023
@rohitwaghchaure
Merge pull request #36057 from frappe/mergify/bp/version-14-hotfix/pr…
16943ac 
…-36001

fix: accepted warehouse and rejected warehouse can't be same (backport #36001)
@s-aga-r s-aga-r mentioned this pull request Sep 13, 2023
Merged
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barredterra barredterra barredterra left review comments

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

@ruthra-kumar ruthra-kumar Awaiting requested review from ruthra-kumar ruthra-kumar is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 buying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohitwaghchaure @barredterra