Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Lead to Address And Contact report #35950

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Jun 30, 2023

feat: add Lead to Address And Contact report

Note to reviewer :

If merge

  • please add back-port to version-14-hotfix and version-13-hotfix label
  • I'll make a PR to add Prospect (but it will be only for version-14-hotfix, but now I would like Lead for version-13)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 30, 2023
@stale
Copy link

stale bot commented Jul 15, 2023

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 15, 2023
@stale stale bot removed the inactive label Jul 16, 2023
@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Merging #35950 (e48dc08) into develop (bd9ef74) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #35950   +/-   ##
========================================
  Coverage    64.16%   64.16%           
========================================
  Files          782      782           
  Lines        60600    60586   -14     
========================================
- Hits         38882    38876    -6     
+ Misses       21718    21710    -8     
Impacted Files Coverage Δ
...eport/address_and_contacts/address_and_contacts.py 0.00% <ø> (ø)
...t/setup/doctype/global_defaults/global_defaults.py 96.87% <ø> (-0.57%) ⬇️
.../setup/setup_wizard/operations/install_fixtures.py 90.75% <ø> (-0.08%) ⬇️
erpnext/accounts/utils.py 73.54% <33.33%> (-0.17%) ⬇️
...evenue_and_expense/deferred_revenue_and_expense.py 61.80% <66.66%> (+0.19%) ⬆️
...rpnext/accounts/doctype/fiscal_year/fiscal_year.py 62.50% <100.00%> (+6.50%) ⬆️
erpnext/hooks.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit de189c5 into frappe:develop Jul 20, 2023
@FHenry FHenry deleted the dev_feat_adress_contact_report branch July 20, 2023 20:34
@FHenry
Copy link
Contributor Author

FHenry commented Aug 1, 2023

@deepeshgarg007
Could you please add back port to version-13 and version-14

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants