Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate table added to track scheduling in the job card. #35921

Conversation

rohitwaghchaure
Copy link
Collaborator

Screenshot 2023-06-28 at 7 24 34 PM

@rohitwaghchaure rohitwaghchaure requested a review from s-aga-r as a code owner June 28, 2023 13:57
@rohitwaghchaure rohitwaghchaure changed the title refactor: A separate table has been added to track scheduling in the job card. refactor: separate table added to track scheduling in the job card. Jun 28, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-seperate-table-for-schedule branch 2 times, most recently from 1e855f9 to 94524cf Compare June 29, 2023 13:59
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-seperate-table-for-schedule branch from 94524cf to 497c83e Compare June 29, 2023 15:22
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #35921 (497c83e) into develop (9a993b0) will decrease coverage by 0.07%.
The diff coverage is 69.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35921      +/-   ##
===========================================
- Coverage    64.22%   64.15%   -0.07%     
===========================================
  Files          811      814       +3     
  Lines        62106    62265     +159     
===========================================
+ Hits         39886    39949      +63     
- Misses       22220    22316      +96     
Impacted Files Coverage Δ
...uring/doctype/workstation_type/workstation_type.py 81.81% <0.00%> (ø)
erpnext/manufacturing/doctype/job_card/job_card.py 72.84% <68.65%> (-0.16%) ⬇️
...job_card_scheduled_time/job_card_scheduled_time.py 100.00% <100.00%> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 80.41% <100.00%> (ø)

... and 18 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 9f1cf0b into frappe:develop Jun 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant