Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset movement #35918

Merged
merged 1 commit into from
Jun 28, 2023
Merged

fix: asset movement #35918

merged 1 commit into from
Jun 28, 2023

Conversation

anandbaburajan
Copy link
Contributor

@anandbaburajan anandbaburajan commented Jun 28, 2023

Asset Movement's UX was confusing -- the unnecessary fields for each 'purpose' weren't made read-only properly hence users couldn't figure out how to transfer issue an Asset to an employee. The docs are insufficient too, so will update them as well.

@anandbaburajan anandbaburajan added backport version-13-hotfix backport develop instructs mergify to frontport PR to develop branch labels Jun 28, 2023
@anandbaburajan anandbaburajan merged commit e16c148 into frappe:version-14-hotfix Jun 28, 2023
@anandbaburajan
Copy link
Contributor Author

@mergify backport version-14

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2023

backport version-14

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 28, 2023
fix: asset movement fixes
(cherry picked from commit e16c148)
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
fix: asset movement fixes
(cherry picked from commit e16c148)
mergify bot pushed a commit that referenced this pull request Jun 28, 2023
fix: asset movement fixes
(cherry picked from commit e16c148)

# Conflicts:
#	erpnext/assets/doctype/asset_movement/asset_movement.py
anandbaburajan added a commit that referenced this pull request Jun 28, 2023
frappe-pr-bot pushed a commit that referenced this pull request Jun 28, 2023
## [14.27.14](v14.27.13...v14.27.14) (2023-06-28)

### Bug Fixes

* asset movement ([#35918](#35918)) ([4f9c28c](4f9c28c))
anandbaburajan added a commit that referenced this pull request Jun 28, 2023
anandbaburajan added a commit that referenced this pull request Jun 28, 2023
* fix: asset movement (#35918)

fix: asset movement fixes
(cherry picked from commit e16c148)

# Conflicts:
#	erpnext/assets/doctype/asset_movement/asset_movement.py

* chore: fix conflict

---------

Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jun 28, 2023
# [14.28.0](v14.27.14...v14.28.0) (2023-06-28)

### Bug Fixes

* asset capitalization ([#35832](#35832)) ([fb823b5](fb823b5))
* asset movement ([#35918](#35918)) ([e16c148](e16c148))
* delivery trip driver is only required on submit (backport [#35876](#35876)) ([#35893](#35893)) ([fc051d1](fc051d1))
* don't allow to make reposting entry for closing stock balance period ([e68b088](e68b088))
* filter parent warehouses not showing (backport [#35897](#35897)) ([#35899](#35899)) ([87ba196](87ba196))
* incorrect cost center error in bank reconciliation ([cacb0f6](cacb0f6))
* issue of asset value_after_depreciation field getting updated twice if workflow is enabled in Journal Entry (backport [#35821](#35821)) ([#35827](#35827)) ([20f2bef](20f2bef))
* make credit note and debit note exclusive ([#35781](#35781)) ([fafb46e](fafb46e))
* multiple Work Orders agaist same production plan ([8ddfc34](8ddfc34))
* no permission for accounts settings on payment reconciliation ([200ddbf](200ddbf))
* Payment Term must be mandatory if `Allocate Payment based on ..` is checked ([#35798](#35798)) ([3dd3935](3dd3935))
* POS Closing Entry load all invoices with one request on save ([#35819](#35819)) ([8ecca2a](8ecca2a))
* reconcile invoice against credit note. ([#35604](#35604)) ([5c388a1](5c388a1))
* Remove special treatment for P&L Accounts ([#35602](#35602)) ([b023448](b023448))
* Set Asset cost center default as PR or PI Item Cost Center while auto creating ([#35844](#35844)) ([4a7d75b](4a7d75b))
* show non-depreciable assets in fixed asset register ([#35858](#35858)) ([42d0944](42d0944))
* TDS amount calculation post LDC breach ([851b887](851b887))
* use correct fieldname for purchase receipt column in item_wise_purchase_register report ([#35828](#35828)) ([8f13b48](8f13b48))
* **ux:** PO Get Items From Open Material Requests (backport [#35894](#35894)) ([#35895](#35895)) ([2ef2057](2ef2057))

### Features

* Auto set Party in Bank Transaction ([#34675](#34675)) ([d53b197](d53b197))
* Provision to send Accounts Receivable Reports using Process SOA ([#35789](#35789)) ([21d560c](21d560c)), closes [#35707](#35707)

### Performance Improvements

* improve item wise register reports ([#35908](#35908)) ([33ee011](33ee011))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

frappe-pr-bot pushed a commit that referenced this pull request Jun 28, 2023
## [13.51.7](v13.51.6...v13.51.7) (2023-06-28)

### Bug Fixes

* asset movement (backport [#35918](#35918)) ([#35924](#35924)) ([0bcd047](0bcd047))
* employee link fields in payroll reports ([#619](#619)) ([#35845](#35845)) ([6c4dff3](6c4dff3))
* filter parent warehouses not showing (backport [#35897](#35897)) ([#35900](#35900)) ([bcfd770](bcfd770))
* frappe.exceptions.DoesNotExistError: DocType KSA VAT Setting ([#35797](#35797)) ([3785fe6](3785fe6)), closes [#35795](#35795)
* show non-depreciable assets in fixed asset register (backport [#35858](#35858)) ([#35861](#35861)) ([2e2c319](2e2c319))
* TDS amount calculation post LDC breach ([#35886](#35886)) ([4dd088c](4dd088c))
* use correct fieldname for purchase receipt column in item_wise_purchase_register report (backport [#35828](#35828)) ([#35848](#35848)) ([de529f0](de529f0))
* **ux:** PO Get Items From Open Material Requests (backport [#35894](#35894)) ([#35896](#35896)) ([12b6257](12b6257))

### Performance Improvements

* improve item wise register reports (backport [#35908](#35908)) ([#35912](#35912)) ([4134459](4134459))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport develop instructs mergify to frontport PR to develop branch backport version-13-hotfix released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants