Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exchange Rate Revaluation should only post on the currency that has balance in a 'zero' balance account #35794

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Jun 20, 2023

On Accounts that have balance only in account currency, Journals created by Exchange Rate Revaluation cause debit - credit mismatch in Trial Balance report. ERR should only post to currencies that have balance.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #35794 (6694175) into develop (2a24423) will decrease coverage by 0.04%.
The diff coverage is 20.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35794      +/-   ##
===========================================
- Coverage    64.13%   64.10%   -0.04%     
===========================================
  Files          810      810              
  Lines        61893    61932      +39     
===========================================
+ Hits         39695    39700       +5     
- Misses       22198    22232      +34     
Impacted Files Coverage Δ
...ange_rate_revaluation/exchange_rate_revaluation.py 56.76% <20.00%> (-0.51%) ⬇️

... and 2 files with indirect coverage changes

@ruthra-kumar ruthra-kumar force-pushed the exchange_revaluation_only_post_on_account_currency_based_on_scenario branch from af676e8 to 6694175 Compare June 20, 2023 07:48
@ruthra-kumar ruthra-kumar merged commit 8aa47a1 into frappe:develop Jun 20, 2023
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Jun 20, 2023
ruthra-kumar added a commit that referenced this pull request Jun 20, 2023
…-35794

fix: Exchange Rate Revaluation should only post on the currency that has balance in a 'zero' balance account (backport #35794)
@dineshpanchal93
Copy link

Are we going to push these changes in version-13 ?

@ruthra-kumar
Copy link
Member Author

@dineshpanchal93
Exchange Rate Revaluation doctype has gone through a major refactor back in January #33165 which was done on v14. The changes in this PR is for the refactored v14 version. This can't be backported to v13.

ruthra-kumar referenced this pull request Aug 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants