Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Index pick list field in stock entry and DN (backport #35738) #35742

Merged
merged 2 commits into from
Jun 17, 2023
Merged

perf: Index pick list field in stock entry and DN (backport #35738) #35742

merged 2 commits into from
Jun 17, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 16, 2023

This is an automatic backport of pull request #35738 done by Mergify.
Cherry-pick of 433489a has failed:

On branch mergify/bp/version-14-hotfix/pr-35738
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 433489a9e6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/stock/doctype/stock_entry/stock_entry.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/stock/doctype/delivery_note/delivery_note.json

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@ankush @mergify
perf: Index pick list field in stock entry and DN (#35738)
138462a 
We check if pick list is created against them but there's no index so we
end up reading entire table.

```
+------+-------------+------------------+-------+---------------+----------+---------+------+--------+-----------+----------+------------+-------------+
| id   | select_type | table            | type  | possible_keys | key      | key_len | ref  | rows   | r_rows    | filtered | r_filtered | Extra       |
+------+-------------+------------------+-------+---------------+----------+---------+------+--------+-----------+----------+------------+-------------+
|    1 | SIMPLE      | tabDelivery Note | index | NULL          | modified | 9       | NULL | 207015 | 348940.00 |   100.00 |       0.00 | Using where |
+------+-------------+------------------+-------+---------------+----------+---------+------+--------+-----------+----------+------------+-------------+
```

After

```
+------+-------------+------------------+------+-----------------+-----------------+---------+-------+------+--------+----------+------------+------------------------------->
| id   | select_type | table            | type | possible_keys   | key             | key_len | ref   | rows | r_rows | filtered | r_filtered | Extra                         >
+------+-------------+------------------+------+-----------------+-----------------+---------+-------+------+--------+----------+------------+------------------------------->
|    1 | SIMPLE      | tabDelivery Note | ref  | pick_list_index | pick_list_index | 563     | const | 1    | 0.00   |   100.00 |     100.00 | Using index condition; Using w>
+------+-------------+------------------+------+-----------------+-----------------+---------+-------+------+--------+----------+------------+------------------------------->
```

(cherry picked from commit 433489a)

# Conflicts:
#	erpnext/stock/doctype/delivery_note/delivery_note.json
@mergify mergify bot added the conflicts label Jun 16, 2023
@mergify mergify bot assigned ankush Jun 16, 2023
@ankush ankush merged commit b875de6 into version-14-hotfix Jun 17, 2023
@ankush ankush removed the conflicts label Jun 17, 2023
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-35738 branch June 17, 2023 15:55
frappe-pr-bot pushed a commit that referenced this pull request Jun 20, 2023
@frappe-bot
chore(release): Bumped to Version 14.27.9
2561cf2 
## [14.27.9](v14.27.8...v14.27.9) (2023-06-20)

### Bug Fixes

* `Process Loss Report` (backport [#35712](#35712)) ([#35719](#35719)) ([55a8be5](55a8be5))
* add validation for QI in PR (backport [#35677](#35677)) ([#35757](#35757)) ([59ab13c](59ab13c))
* Allocated amount validation for other party types ([#35741](#35741)) ([5541d68](5541d68))
* cannot start / stop jobs ([53ec2a9](53ec2a9))
* conflicts ([697fcef](697fcef))
* consider field precision while setting sle actual_qty ([#35717](#35717)) ([3f62e85](3f62e85))
* date and finance book fixes in fixed asset register (backport [#35751](#35751)) ([#35799](#35799)) ([8b57ecd](8b57ecd))
* don't add GL Entry for Acc. Depr. while scrapping non-depreciable assets (backport [#35714](#35714)) ([#35715](#35715)) ([77b0c5f](77b0c5f))
* Duplicate addresses are creating while using the E-commerce ([703e4f4](703e4f4))
* fix get outstanding invoices btn and add get outstanding orders btn (backport [#35776](#35776)) ([#35787](#35787)) ([42e25d4](42e25d4))
* for zero bal accounts, dr/cr only on currency that has balance ([7da461b](7da461b))
* incorrect gl entries for standalone debit note with update stock ([3355dc2](3355dc2))
* incorrect stock value for purchase returned with rejected qty (backport [#35747](#35747)) ([#35752](#35752)) ([c11d950](c11d950))
* keyerror while checking the stock balance report ([baf014f](baf014f))
* loan interest accrual date ([#35695](#35695)) ([070df97](070df97))
* **patch:** enable existing serial no in stock settings ([#35762](#35762)) ([3c790c1](3c790c1))
* stock error for service item ([2bbea63](2bbea63))
* test case ([4af0a9b](4af0a9b))
* unsupported operand type(s) for //: 'float' and 'NoneType' for POS Barcode search ([#35710](#35710)) ([58a6bbc](58a6bbc))
* update `Stock Reconciliation` diff qty while reposting ([bdb5cc8](bdb5cc8))
* **ux:** set route options for new `Batch` ([b261242](b261242))
* validation of job card in stock entry ([ce2bf5f](ce2bf5f))
* work order serial no issue ([50a8907](50a8907))

### Performance Improvements

* Duplicate queries for UOM (backport [#35744](#35744)) ([#35745](#35745)) ([632b67c](632b67c))
* duplicate queries while checking prevdoc (backport [#35746](#35746)) ([#35749](#35749)) ([a0fc8e2](a0fc8e2))
* Ignore cancelled pick lists while fetching picked items (backport [#35737](#35737)) ([#35740](#35740)) ([01ac54d](01ac54d))
* index `purpose` in `Stock Entry` (backport [#35782](#35782)) ([#35783](#35783)) ([3bac2a8](3bac2a8))
* Index pick list field in stock entry and DN (backport [#35738](#35738)) ([#35742](#35742)) ([b875de6](b875de6))
* Index sales_order_item in Pick list item (backport [#35735](#35735)) ([#35736](#35736)) ([0e57f4d](0e57f4d))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.27.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees

@ankush ankush

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frappe-pr-bot @ankush