Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify filters for account in journal entry #35626

Merged
merged 1 commit into from
Jun 18, 2023

Conversation

ljain112
Copy link
Collaborator

@ljain112 ljain112 commented Jun 9, 2023

Please provide enough information so that others can review your pull request:

  • In taxes account setup, account currency for tax account is not been set.
  • Only Accounts with default currency are allowed while creating journal Entry without multi currency so tax accounts are not shown.
  • User Not able to create opening entries for tax account because currency not set in tax account.
    Discuss Issue Link

Explain the details for making this change. What existing problem does the pull request solve?

Modifying query in journal entry doctype to include accounts with empty currency also.

Screenshots/GIFs

Account Currency empty in Tax accounts.
Screenshot from 2023-06-09 18-00-55

Filter Query in Journal Entry Requiring Default currency.
Screenshot from 2023-06-09 18-11-47

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 9, 2023
@rtdany10
Copy link
Contributor

Won't it be better to tweak the account filter in JE?
If selected currency(JE) is same as the default company currency, list all accounts with no currency set and also the ones with that particular currency.

@ljain112 ljain112 force-pushed the fix-taxes-currency branch from c200a1f to 9a5d627 Compare June 15, 2023 05:45
@ljain112 ljain112 changed the title fix: set account currency in taxes on setup fix: fix: modify filters for account in journal entry Jun 15, 2023
@ljain112 ljain112 changed the title fix: fix: modify filters for account in journal entry fix: modify filters for account in journal entry Jun 15, 2023
@ljain112 ljain112 marked this pull request as draft June 15, 2023 06:00
@ljain112 ljain112 force-pushed the fix-taxes-currency branch from 9a5d627 to 327fdc6 Compare June 15, 2023 11:07
@ljain112 ljain112 force-pushed the fix-taxes-currency branch from 327fdc6 to 3e7d429 Compare June 15, 2023 11:10
@ljain112 ljain112 marked this pull request as ready for review June 15, 2023 11:22
@deepeshgarg007 deepeshgarg007 merged commit 93c0c26 into frappe:develop Jun 18, 2023
@ljain112 ljain112 deleted the fix-taxes-currency branch June 19, 2023 05:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants