Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't allow to make reposting entry for closing stock balance period #35611

Conversation

rohitwaghchaure
Copy link
Collaborator

User shouldn't be able to create the Reposting Entry if the closing stock balance has already been created for the same period.

After Changes

Created closing stock balance for the 31st May 2023 and tried to create reposting entry for the 16th May 2023 then system has throw the below error

Screenshot 2023-06-08 at 5 06 52 PM

@rohitwaghchaure rohitwaghchaure requested a review from s-aga-r as a code owner June 8, 2023 11:42
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #35611 (96c5c7b) into develop (9e650a0) will increase coverage by 0.35%.
The diff coverage is 88.23%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35611      +/-   ##
===========================================
+ Coverage    63.92%   64.27%   +0.35%     
===========================================
  Files          812      811       -1     
  Lines        61792    62051     +259     
===========================================
+ Hits         39501    39886     +385     
+ Misses       22291    22165     -126     
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 74.65% <88.23%> (+1.52%) ⬆️

... and 54 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure removed the needs-tests This PR needs automated unit-tests. label Jun 8, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the fix-dont-allow-to-create-reposting-entry-for-closing-stock-balance branch from d5db5e6 to 05a9506 Compare June 8, 2023 12:38
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label Jun 8, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the fix-dont-allow-to-create-reposting-entry-for-closing-stock-balance branch from 05a9506 to 96c5c7b Compare June 21, 2023 06:26
@rohitwaghchaure rohitwaghchaure merged commit edc38ed into frappe:develop Jun 21, 2023
rohitwaghchaure added a commit that referenced this pull request Jun 22, 2023
…-35611

fix: don't allow to make reposting entry for closing stock balance period (backport #35611)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant