Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing bom details in the stock entry #35482

Merged
merged 1 commit into from
May 31, 2023
Merged

fix: missing bom details in the stock entry #35482

merged 1 commit into from
May 31, 2023

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented May 30, 2023 •
edited
Loading

Fixed #35215

After Fix
material-request-bom-fix

@rohitwaghchaure rohitwaghchaure requested a review from s-aga-r as a code owner May 30, 2023 12:22
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #35482 (2fc7d82) into develop (ffd5308) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #35482      +/-   ##
===========================================
+ Coverage    63.98%   64.00%   +0.02%     
===========================================
  Files          815      815              
  Lines        60767    60773       +6     
===========================================
+ Hits         38880    38896      +16     
+ Misses       21887    21877      -10
Impacted Files Coverage Δ
...stock/doctype/material_request/material_request.py 74.68% <100.00%> (+0.81%) ⬆️

... and 3 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-stock-entry-missing-bom-details branch from 4e25fa7 to 2fc7d82 Compare May 30, 2023 12:53
@rohitwaghchaure rohitwaghchaure added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels May 30, 2023
@rohitwaghchaure rohitwaghchaure merged commit cb19ebc into frappe:develop May 31, 2023
@mergify mergify bot mentioned this pull request May 31, 2023
Merged
rohitwaghchaure added a commit that referenced this pull request May 31, 2023
@rohitwaghchaure
Merge pull request #35506 from frappe/mergify/bp/version-14-hotfix/pr…
6835efa 
…-35482

fix: missing bom details in the stock entry (backport #35482)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job card is not submitted while transfer against the Material Request, Stock Entry.
1 participant
@rohitwaghchaure