Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancelled vouchers in tax withheld vouchers list #35309

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: cancelled vouchers in tax withheld vouchers list #35309

merged 1 commit into from
May 16, 2023

Conversation

ruthra-kumar
Copy link
Member

If one of the tax_withheld_vouchers in purchase invoice is cancelled, then document cannot be submitted.

frappe.exceptions.CancelledLinkError: Cannot link cancelled document: Row #1: Voucher Name: PINV-23-00020-1

Just uncheck and check Apply TDS to clear the tax_withheld_vouchers list

@ruthra-kumar ruthra-kumar marked this pull request as ready for review May 15, 2023 16:27
@deepeshgarg007 deepeshgarg007 merged commit 776a830 into frappe:develop May 16, 2023
mergify bot pushed a commit that referenced this pull request May 16, 2023
@ruthra-kumar @mergify
fix: cancelled vouchers in tax withheld vouchers list (#35309)
4a08cf7 
(cherry picked from commit 776a830)
mergify bot pushed a commit that referenced this pull request May 16, 2023
@ruthra-kumar @mergify
fix: cancelled vouchers in tax withheld vouchers list (#35309)
fb45fb7 
(cherry picked from commit 776a830)
This was referenced May 16, 2023
Merged
Merged
deepeshgarg007 pushed a commit that referenced this pull request May 16, 2023
@mergify @ruthra-kumar
fix: cancelled vouchers in tax withheld vouchers list (#35309)
c41e1d7 
fix: cancelled vouchers in tax withheld vouchers list (#35309)

(cherry picked from commit 776a830)

Co-authored-by: ruthra kumar <ruthra@erpnext.com>
deepeshgarg007 pushed a commit that referenced this pull request May 16, 2023
@mergify @ruthra-kumar
fix: cancelled vouchers in tax withheld vouchers list (#35309)
188cfc2 
fix: cancelled vouchers in tax withheld vouchers list (#35309)

(cherry picked from commit 776a830)

Co-authored-by: ruthra kumar <ruthra@erpnext.com>
frappe-pr-bot pushed a commit that referenced this pull request May 16, 2023
@frappe-bot
chore(release): Bumped to Version 13.50.4
c2ae8ea 
## [13.50.4](v13.50.3...v13.50.4) (2023-05-16)

### Bug Fixes

* add missing options for `Content Align` ([e37b903](e37b903))
* cancelled vouchers in tax withheld vouchers list ([#35309](#35309)) ([188cfc2](188cfc2))
* internal transfer condition ([a1d7170](a1d7170))
* **Salary Slip:** exchange rate overwritten on form load ([#507](#507)) ([#35245](#35245)) ([8b3d6ee](8b3d6ee))
* update reference data for statistical component ([77f548c](77f548c))
frappe-pr-bot pushed a commit that referenced this pull request May 16, 2023
@frappe-bot
chore(release): Bumped to Version 14.24.2
7076c23 
## [14.24.2](v14.24.1...v14.24.2) (2023-05-16)

### Bug Fixes

* add missing options for `Content Align` ([3697e8f](3697e8f))
* allow over-payment against SO ([#35079](#35079)) ([fe9e0c2](fe9e0c2))
* bad strings format for command get-untraslated  ([#34361](#34361)) ([5a54296](5a54296))
* bad strings format for update-translations ([#34592](#34592)) ([e3c1d73](e3c1d73))
* bom item filter issue ([098603d](098603d))
* cancelled vouchers in tax withheld vouchers list ([#35309](#35309)) ([c41e1d7](c41e1d7))
* enqueue submit/cancel action for stock entry to avoid time out error ([457846e](457846e))
* force to do reposting for cancelled document ([6f96e5d](6f96e5d))
* function `batch_no` should only be declared once ([#35115](#35115)) ([26928b3](26928b3))
* incorrect packing items ([ab56470](ab56470))
* inventory dimension for inter company transfer return use case ([6d121b8](6d121b8))
* inventory dimension for material transfer not working ([1d8050d](1d8050d))
* item list view not working ([d9efa66](d9efa66))
* port option for additional_conditions in item wise sales register ([#35187](#35187)) ([42037f9](42037f9))
* recalculate costs in SCR while reposting ([9a8ee62](9a8ee62))
* sales person allocated amount calculation error nonetype and float ([#35293](#35293)) ([3a7c69f](3a7c69f))
* test case ([3f8928b](3f8928b))
* test case ([9b2b467](9b2b467))
* typo ([2772a91](2772a91))
* unable to create partial invoice with auto fetch terms enabled ([#35285](#35285)) ([fa9fa97](fa9fa97))
* update workstation hour rate when workstation change in job card ([bc88415](bc88415))
* **UX:** misc "home" onboarding improvements (backport [#35319](#35319)) ([#35321](#35321)) ([f8c58b6](f8c58b6))
* validate for active sla ([#32132](#32132)) ([38e27a6](38e27a6))

### Performance Improvements

* cache and simplify queries for holiday list (backport [#35315](#35315)) ([#35318](#35318)) ([0e78403](0e78403))
@ruthra-kumar ruthra-kumar deleted the fix_cancelled_vouchers_in_tax_withheld_list branch June 14, 2023 16:02
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruthra-kumar @deepeshgarg007