Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed type of column 'serial_no' in Stock Reconciliation to fix Data too Long error #35230

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

Screenshot 2023-05-09 at 6 11 36 PM

Fix

Changed fieldtype from Small Text to Long Text

@rohitwaghchaure rohitwaghchaure requested a review from s-aga-r as a code owner May 9, 2023 13:16
@rohitwaghchaure rohitwaghchaure changed the title fix: Changed type of column 'serial_no' in Stock Reconciliation to fi… fix: Changed type of column 'serial_no' in Stock Reconciliation to fix Data too Long error May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #35230 (1a673fd) into develop (3993bfd) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35230      +/-   ##
===========================================
+ Coverage    63.71%   63.75%   +0.03%     
===========================================
  Files          813      813              
  Lines        60102    60121      +19     
===========================================
+ Hits         38296    38331      +35     
+ Misses       21806    21790      -16     

see 7 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 5d43b35 into frappe:develop May 9, 2023
@rohitwaghchaure rohitwaghchaure added the backport version-14-hotfix backport to version 14 label May 9, 2023
rohitwaghchaure added a commit that referenced this pull request May 9, 2023
…-35230

fix: Changed type of column 'serial_no' in Stock Reconciliation to fix Data too Long error (backport #35230)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant