Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report link, option, and added a link for Sales Person in GP #35077

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

Solufyin
Copy link
Contributor

Version:

ERPNext: v14.23.0 (version-14)
Frappe Framework: v14.34.0 (version-14)

fixes #35072


Before:

  • When selecting a group by Item Group, Brand, Warehouse, Customer, Customer Group, Territory, Sales Person, Project, and Payment Term, then click on columns that are linked so all links go to the item master
/item/....
before_gp_link.mp4

After:

  • After setting the filter condition in gross_profit.js and report work properly with the link.
  • Set the option in Warehouse, Customer Group, and Territory.
  • Also added a link option for Sales Person.
after_gp_link.mp4

Thanks and Regards,
Nihantra Patel (NCP)

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 27, 2023
@ruthra-kumar ruthra-kumar self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #35077 (6dfca79) into develop (01bfd2a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35077      +/-   ##
===========================================
- Coverage    63.69%   63.69%   -0.01%     
===========================================
  Files          813      813              
  Lines        60019    60019              
===========================================
- Hits         38228    38227       -1     
- Misses       21791    21792       +1     
Impacted Files Coverage Δ
...pnext/accounts/report/gross_profit/gross_profit.py 87.76% <ø> (ø)

... and 1 file with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 787313b into frappe:develop Apr 27, 2023
@ruthra-kumar ruthra-kumar added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Apr 27, 2023
ruthra-kumar added a commit that referenced this pull request Apr 27, 2023
…-35077

fix: Report link, option, and added a link for Sales Person in GP (backport #35077)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report Linking
3 participants