fix: bom update log not working for large batch size (backport #34715) #34719
+2
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit d560703)
|
@Mergifyio backport version-14 |
✅ Backports have been created
|
|
🎉 This PR is included in version 14.21.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
marination
reviewed
Jul 18, 2023
Comment on lines
214
to
217
| incomplete_level = any(row.get("status") == "Pending" for row in bom_batches) | ||
| if not bom_batches or not incomplete_level: | ||
| if not bom_batches or incomplete_level: | ||
| continue | ||
|
|
There was a problem hiding this comment.
- We want to continue or skip processing if there are no batches to process or if all rows are completed.
- Here
not incomplete_levelmeant all levels are complete/there are no pending rows to process. - We don't want to skip if there is an incomplete level (which is happening now?), we want to process it
To simplify this, a newer snippet:
all_complete = all(row.get("status") == "Completed" for row in bom_batches)
if not bom_batches or all_complete:
continue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #34715 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com