Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BOM Update Cost, when no actual qty #34656

Merged
merged 4 commits into from
Apr 1, 2023
Merged

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Mar 30, 2023

  • Bin Actual Qty is 0.
    image
  • Valuation Rate is not set in Item Master.
    image

Before:

image

After:

image

closes: #33830

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 30, 2023
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 backport version-13-hotfix and removed needs-tests This PR needs automated unit-tests. labels Mar 30, 2023
@s-aga-r s-aga-r marked this pull request as ready for review March 30, 2023 08:23
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #34656 (2c2b5a5) into develop (e56d40f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #34656   +/-   ##
========================================
  Coverage    63.80%   63.80%           
========================================
  Files          810      810           
  Lines        59538    59539    +1     
========================================
+ Hits         37987    37988    +1     
  Misses       21551    21551           
Impacted Files Coverage Δ
erpnext/manufacturing/doctype/bom/bom.py 75.18% <100.00%> (+0.03%) ⬆️

@s-aga-r s-aga-r merged commit 7c7cfc4 into frappe:develop Apr 1, 2023
s-aga-r added a commit that referenced this pull request Apr 2, 2023
…-34656

fix: BOM Update Cost, when no actual qty (backport #34656)
s-aga-r added a commit that referenced this pull request Apr 2, 2023
…-34656

fix: BOM Update Cost, when no actual qty (backport #34656)
@s-aga-r s-aga-r deleted the FIX-33830 branch April 15, 2023 09:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BOM Update Cost set 0$ when no actual qty
1 participant