Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite batch.py queries in QB #34632

Merged
merged 3 commits into from
Apr 8, 2023
Merged

refactor: rewrite batch.py queries in QB #34632

merged 3 commits into from
Apr 8, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Mar 29, 2023

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 29, 2023
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #34632 (299fb26) into develop (ba553db) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #34632   +/-   ##
========================================
  Coverage    63.84%   63.84%           
========================================
  Files          810      810           
  Lines        59708    59712    +4     
========================================
+ Hits         38118    38122    +4     
  Misses       21590    21590
Impacted Files Coverage Δ
erpnext/stock/doctype/batch/batch.py 83.33% <66.66%> (+0.40%) ⬆️

@s-aga-r s-aga-r closed this Apr 6, 2023
@s-aga-r s-aga-r reopened this Apr 7, 2023
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Apr 7, 2023
@s-aga-r s-aga-r marked this pull request as ready for review April 7, 2023 16:02
@s-aga-r s-aga-r requested a review from rohitwaghchaure as a code owner April 7, 2023 16:02
@s-aga-r s-aga-r removed the needs-tests This PR needs automated unit-tests. label Apr 7, 2023
@s-aga-r s-aga-r merged commit 02d5d43 into frappe:develop Apr 8, 2023
@mergify mergify bot mentioned this pull request Apr 8, 2023
Merged
@s-aga-r s-aga-r added refactor and removed backport version-14-hotfix backport to version 14 labels Apr 8, 2023
s-aga-r added a commit that referenced this pull request Apr 8, 2023
@s-aga-r
Merge pull request #34786 from frappe/mergify/bp/version-14-hotfix/pr…
66fdd1c 
…-34632

refactor: rewrite `batch.py` queries in `QB` (backport #34632)
@s-aga-r s-aga-r deleted the refactor-batch branch April 15, 2023 09:57
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@s-aga-r