Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get batch_no. for item automatically #34473

Conversation

Shram007
Copy link
Contributor

Issue:

  • When selecting an item for POS, batch no. for the item wasn't selected automatically. one would have to select it manually like shown below:

error_batch_selection

Fix:

  • adding batch no. to result. It now works in the following way:

fix_atch_selection

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 16, 2023
@deepeshgarg007 deepeshgarg007 changed the title Fix get batch_no. for item automatically fix: get batch_no. for item automatically Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #34473 (eb9c495) into develop (2942cee) will decrease coverage by 0.24%.
The diff coverage is 84.03%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34473      +/-   ##
===========================================
- Coverage    64.09%   63.85%   -0.24%     
===========================================
  Files          810      810              
  Lines        59372    59493     +121     
===========================================
- Hits         38052    37987      -65     
- Misses       21320    21506     +186     
Impacted Files Coverage Δ
...ement_of_accounts/process_statement_of_accounts.py 0.00% <0.00%> (ø)
...ext/accounts/report/trial_balance/trial_balance.py 0.00% <0.00%> (ø)
erpnext/hooks.py 100.00% <ø> (ø)
...facturing/doctype/bom_update_log/bom_update_log.py 42.60% <0.00%> (-44.12%) ⬇️
...rpnext/selling/page/point_of_sale/point_of_sale.py 43.90% <0.00%> (ø)
...stock/doctype/item_alternative/item_alternative.py 0.00% <0.00%> (ø)
erpnext/www/book_appointment/index.py 0.00% <0.00%> (ø)
erpnext/controllers/website_list_for_contact.py 53.54% <42.85%> (+0.05%) ⬆️
erpnext/utilities/doctype/video/video.py 23.07% <50.00%> (+0.85%) ⬆️
erpnext/controllers/sales_and_purchase_return.py 90.52% <55.55%> (-1.26%) ⬇️
... and 16 more

... and 10 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Mar 24, 2023
@deepeshgarg007 deepeshgarg007 merged commit 0cd870f into frappe:develop Mar 24, 2023
mergify bot pushed a commit that referenced this pull request Mar 24, 2023
* fix: default pos conversion factor set to 1

* fix:get-batch-no-of-item-automatically

(cherry picked from commit 0cd870f)

# Conflicts:
#	erpnext/selling/page/point_of_sale/point_of_sale.py
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants