Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use customer name instead of name(id) in PSOA #34412

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Mar 12, 2023

Process Statement of Accounts uses the customer's primary key in prints and emails instead of the Customer's Name.
This could be confusing for users using naming series for customer records. Made a change in this PR to use customer_name field instead

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Mar 12, 2023
@deepeshgarg007 deepeshgarg007 merged commit fa776d2 into frappe:develop Mar 13, 2023
mergify bot pushed a commit that referenced this pull request Mar 13, 2023
mergify bot pushed a commit that referenced this pull request Mar 13, 2023
deepeshgarg007 added a commit that referenced this pull request Mar 13, 2023
…34426)

fix: Use customer name instead of name(id) in PSOA (#34412)

(cherry picked from commit fa776d2)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
deepeshgarg007 added a commit that referenced this pull request Mar 13, 2023
…34425)

fix: Use customer name instead of name(id) in PSOA (#34412)

(cherry picked from commit fa776d2)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Mar 14, 2023
## [13.49.5](v13.49.4...v13.49.5) (2023-03-14)

### Bug Fixes

* `BOM Stock Report` ([eb1f8f9](eb1f8f9))
* `required_qty` get reset to `1` for Alternative Item in WO ([d117101](d117101))
* adjust excess cf leaves in new leaves taken if number exceeds cf leaves allocation ([bc12269](bc12269))
* consider leaves taken while calculating expired carry-forwarded leaves ([e74e02b](e74e02b))
* consider leaves taken within carry-forwarded period separately while calculating balance ([52108d5](52108d5))
* consider relieving date while calculating payment days based on lwp ([563f83f](563f83f))
* Don't use get_list & get_all interchangeably ([b70a37f](b70a37f))
* Error in consolidated financial statement ([#34330](#34330)) ([470dc10](470dc10))
* exclude cancelled leave ledger entries ([91cad9e](91cad9e))
* exclude carry forwarding leaves while updating leaves after submission ([88c5de5](88c5de5))
* leave allocation tests ([2f62a96](2f62a96))
* linter ([341eab2](341eab2))
* operation time for multi-level BOM in WO ([f4d07cc](f4d07cc))
* precision for newly allocated leaves ([238769e](238769e))
* **test:** `get_leave_allocation_records` ([c01bed9](c01bed9))
* **test:** `TestBomStockReport` ([4824302](4824302))
* Total row in trail balance report (backport [#34395](#34395)) ([#34431](#34431)) ([809d6d6](809d6d6))
* Use customer name instead of name(id) in PSOA (backport [#34412](#34412)) ([#34426](#34426)) ([a24f050](a24f050))

### Performance Improvements

* `update_completed_qty()` in `material_request.py` ([5bc2b8f](5bc2b8f))
* Stock Entry (Material Transfer) ([7a159a7](7a159a7))

### Reverts

* Revert "fix: Default sales team not getting set" (#34376) ([42bda6e](42bda6e)), closes [#34376](#34376) [#34376](#34376) [#34284](#34284)
frappe-pr-bot pushed a commit that referenced this pull request Mar 14, 2023
## [14.18.3](v14.18.2...v14.18.3) (2023-03-14)

### Bug Fixes

* `BOM Stock Report` ([1c00077](1c00077))
* `required_qty` get reset to `1` for Alternative Item in WO ([51bcdb3](51bcdb3))
* Don't use get_list & get_all interchangeably ([27c524e](27c524e))
* Error in consolidated financial statement ([#34330](#34330)) ([73866f4](73866f4))
* exchange rate revaluation errors ([#33947](#33947)) ([1a629b6](1a629b6))
* filters not getting applied on `Web Form` ([6ef7ddf](6ef7ddf))
* Linked invoice cancellation issue via timesheet ([#34337](#34337)) ([da8cc2b](da8cc2b))
* operation time for multi-level BOM in WO ([76e04c8](76e04c8))
* Set contact filter link in Opportunity ([#34325](#34325)) ([c64836d](c64836d))
* set tax category from address before executing `get_regional_address_details` ([#34372](#34372)) ([bf0cbe0](bf0cbe0))
* **test:** flaky test case in Payment terms report ([69a5411](69a5411))
* Total row in trail balance report ([#34395](#34395)) ([c353ba7](c353ba7))
* Use customer name instead of name(id) in PSOA (backport [#34412](#34412)) ([#34425](#34425)) ([209adf3](209adf3))

### Performance Improvements

* `update_completed_qty()` in `material_request.py` ([b37712c](b37712c))
* Stock Entry (Material Transfer) ([1b51463](1b51463))

### Reverts

* Revert "Update tr.csv (backport #34285)" (#34427) ([b6d059c](b6d059c)), closes [#34285](#34285) [#34427](#34427) [#34285](#34285)
* Revert "fix: Default sales team not getting set" (#34376) ([ed338b1](ed338b1)), closes [#34376](#34376) [#34376](#34376) [#34284](#34284)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant