Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forced delete linked desktop_icons #34107

Merged
merged 2 commits into from
Feb 19, 2023
Merged

Conversation

shadrak98
Copy link
Contributor

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #34107 (17659bd) into develop (067f8c1) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34107      +/-   ##
===========================================
- Coverage    63.89%   63.88%   -0.01%     
===========================================
  Files          817      817              
  Lines        59331    59331              
===========================================
- Hits         37907    37906       -1     
- Misses       21424    21425       +1     
Impacted Files Coverage Δ
erpnext/stock/doctype/serial_no/serial_no.py 89.20% <0.00%> (-0.24%) ⬇️

@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Feb 19, 2023
@deepeshgarg007 deepeshgarg007 merged commit 5e48e61 into develop Feb 19, 2023
mergify bot pushed a commit that referenced this pull request Feb 19, 2023
* fix: forced delete linked desktop_icons

* fix: black

(cherry picked from commit 5e48e61)
deepeshgarg007 pushed a commit that referenced this pull request Feb 19, 2023
fix: forced delete linked desktop_icons (#34107)

* fix: forced delete linked desktop_icons

* fix: black

(cherry picked from commit 5e48e61)

Co-authored-by: Shadrak Gurupnor <30501401+shadrak98@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Feb 21, 2023
# [14.17.0](v14.16.1...v14.17.0) (2023-02-21)

### Bug Fixes

* asset repair status after deletion and asset status after manual depr entry ([03f07a2](03f07a2))
* asset_depreciation_and_balances report doesn't reflect manual depr entries ([1535c3d](1535c3d))
* change parameter name for letter head ([4f37ba9](4f37ba9))
* check for duplicate in pos closing and pos merge log entry ([05d6490](05d6490))
* consider rounded total amount while making payment request ([#34110](#34110)) ([7879564](7879564))
* create `Delivery Trip` from `Delivery Note` list ([ba5ea88](ba5ea88))
* differency entry journal debit/credit missing ([#34104](#34104)) ([7556739](7556739))
* Filters in item-wise sales history report ([#34145](#34145)) ([44c837f](44c837f))
* fiscal year error for existing assets in fixed asset register ([7074c2b](7074c2b))
* forced delete linked desktop_icons (backport [#34107](#34107)) ([#34130](#34130)) ([53ab4d9](53ab4d9))
* ignore repost payment ledger on basic documents cancellation ([#34054](#34054)) ([9890cce](9890cce))
* incorrect consumed qty in subcontracting receipt ([d5f6a5d](d5f6a5d))
* inventory dimension filter not overriding with existing filter for stock ledger report ([6959283](6959283))
* linters issue ([f65e471](f65e471))
* opening_accumulated_depreciation and precision in charts ([47cc8ab](47cc8ab))
* purchase invoice performance issue ([8d98599](8d98599))
* rename duplicate field name with same type into a DocType to avoid import Error ([#34053](#34053)) ([d783168](d783168))
* show Purchase Order Portal `Pay` button based on configuration ([84da0c6](84da0c6))
* update `reserved_qty` when `Sales Order` marked as `Hold` ([15898cc](15898cc))
* Use normal rounding for Tax Withholding Category ([#34114](#34114)) ([65aec3e](65aec3e))
* **ux:** `ReferenceError: me is not defined` Delivery Note ([7bd04c2](7bd04c2))

### Features

* allow to make in transit transfer entry from material request ([a7b682e](a7b682e))
* Editable Sales Invoice ([#32625](#32625)) ([00eb632](00eb632))
* provision to convert transaction based reposting to item warehouse based reposting ([72c0b22](72c0b22))
* translate fixtures during runtime, not installation ([#33996](#33996)) ([d117de7](d117de7))
@barredterra barredterra mentioned this pull request Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants