Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for duplicate pos invoices in closing entry #34102

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: check for duplicate pos invoices in closing entry #34102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions erpnext/accounts/doctype/pos_closing_entry/pos_closing_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,24 @@ def validate(self):
if frappe.db.get_value("POS Opening Entry", self.pos_opening_entry, "status") != "Open":
frappe.throw(_("Selected POS Opening Entry should be open."), title=_("Invalid Opening Entry"))

self.validate_duplicate_pos_invoices()
self.validate_pos_invoices()

def validate_duplicate_pos_invoices(self):
pos_occurences = {}
for idx, inv in enumerate(self.pos_transactions, 1):
pos_occurences.setdefault(inv.pos_invoice, []).append(idx)

error_list = []
for key, value in pos_occurences.items():
if len(value) > 1:
error_list.append(
_("{} is added multiple times on rows: {}".format(frappe.bold(key), frappe.bold(value)))
)

if error_list:
frappe.throw(error_list, title=_("Duplicate POS Invoices found"), as_list=True)

def validate_pos_invoices(self):
invalid_rows = []
for d in self.pos_transactions:
Expand Down
18 changes: 18 additions & 0 deletions erpnext/accounts/doctype/pos_invoice_merge_log/pos_invoice_merge_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ class POSInvoiceMergeLog(Document):
def validate(self):
self.validate_customer()
self.validate_pos_invoice_status()
self.validate_duplicate_pos_invoices()

def validate_duplicate_pos_invoices(self):
pos_occurences = {}
for idx, inv in enumerate(self.pos_invoices, 1):
pos_occurences.setdefault(inv.pos_invoice, []).append(idx)

error_list = []
for key, value in pos_occurences.items():
if len(value) > 1:
error_list.append(
_("{} is added multiple times on rows: {}".format(frappe.bold(key), frappe.bold(value)))
)

if error_list:
frappe.throw(error_list, title=_("Duplicate POS Invoices found"), as_list=True)

def validate_customer(self):
if self.merge_invoices_based_on == "Customer Group":
Expand Down Expand Up @@ -425,6 +441,8 @@ def create_merge_logs(invoice_by_customer, closing_entry=None):

if closing_entry:
closing_entry.set_status(update=True, status="Failed")
if type(error_message) == list:
error_message = frappe.json.dumps(error_message)
closing_entry.db_set("error_message", error_message)
raise

Expand Down