Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for duplicate pos invoices in closing entry #34102

Conversation

ruthra-kumar
Copy link
Member

POS Closing entry was accepting duplicate pos invoices. Validation has been added to prevent it.

Screenshot 2023-02-16 at 8 42 18 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #34102 (47add0b) into develop (20bdc63) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #34102      +/-   ##
===========================================
- Coverage    63.88%   63.87%   -0.02%     
===========================================
  Files          817      817              
  Lines        59330    59536     +206     
===========================================
+ Hits         37905    38026     +121     
- Misses       21425    21510      +85     
Impacted Files Coverage Δ
...ype/pos_invoice_merge_log/pos_invoice_merge_log.py 79.67% <69.23%> (-0.46%) ⬇️
...nts/doctype/pos_closing_entry/pos_closing_entry.py 77.27% <81.81%> (+0.50%) ⬆️
...ock_reposting_settings/stock_reposting_settings.py 29.26% <0.00%> (-4.07%) ⬇️
...egrations/doctype/plaid_settings/plaid_settings.py 46.15% <0.00%> (-2.92%) ⬇️
...ounts/doctype/bank_transaction/bank_transaction.py 67.46% <0.00%> (-2.91%) ⬇️
...nk_reconciliation_tool/bank_reconciliation_tool.py 41.43% <0.00%> (-2.70%) ⬇️
erpnext/accounts/general_ledger.py 94.31% <0.00%> (-0.76%) ⬇️
...rpnext/assets/doctype/asset_repair/asset_repair.py 65.85% <0.00%> (-0.20%) ⬇️
...x_withholding_category/tax_withholding_category.py 85.95% <0.00%> (-0.01%) ⬇️
erpnext/setup/doctype/employee/employee.py 57.76% <0.00%> (ø)
... and 12 more

@ruthra-kumar ruthra-kumar force-pushed the pos_validate_for_duplicate_pos_invoices branch from cb27975 to 890c8a0 Compare February 17, 2023 04:42
@ruthra-kumar ruthra-kumar force-pushed the pos_validate_for_duplicate_pos_invoices branch from 890c8a0 to 47add0b Compare February 21, 2023 12:22
@ruthra-kumar ruthra-kumar merged commit dde5bbc into frappe:develop Feb 21, 2023
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14-hotfix version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Feb 21, 2023

backport version-14-hotfix version-13-hotfix

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Feb 21, 2023
…-34102

fix: check for duplicate pos invoices in closing entry (backport #34102)
ruthra-kumar added a commit that referenced this pull request Feb 21, 2023
…-34102

fix: check for duplicate pos invoices in closing entry (backport #34102)
@ruthra-kumar ruthra-kumar deleted the pos_validate_for_duplicate_pos_invoices branch June 14, 2023 16:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant