-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for duplicate pos invoices in closing entry #34102
Merged
ruthra-kumar
merged 1 commit into
frappe:develop
from
ruthra-kumar:pos_validate_for_duplicate_pos_invoices
Feb 21, 2023
Merged
fix: check for duplicate pos invoices in closing entry #34102
ruthra-kumar
merged 1 commit into
frappe:develop
from
ruthra-kumar:pos_validate_for_duplicate_pos_invoices
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #34102 +/- ##
===========================================
- Coverage 63.88% 63.87% -0.02%
===========================================
Files 817 817
Lines 59330 59536 +206
===========================================
+ Hits 37905 38026 +121
- Misses 21425 21510 +85
|
cb27975
to
890c8a0
Compare
890c8a0
to
47add0b
Compare
@Mergifyio backport version-14-hotfix version-13-hotfix |
✅ Backports have been created
|
This was referenced Feb 21, 2023
ruthra-kumar
added a commit
that referenced
this pull request
Feb 21, 2023
…-34102 fix: check for duplicate pos invoices in closing entry (backport #34102)
ruthra-kumar
added a commit
that referenced
this pull request
Feb 21, 2023
…-34102 fix: check for duplicate pos invoices in closing entry (backport #34102)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POS Closing entry was accepting duplicate pos invoices. Validation has been added to prevent it.