Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update reserved_qty when Sales Order marked as Hold #34018

Merged
merged 4 commits into from
Feb 14, 2023
Merged

fix: update reserved_qty when Sales Order marked as Hold #34018

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d76759e
fix: update `reserved_qty` when `Sales Order` marked as `Hold`
s-aga-r Feb 6, 2023
b0e8dfc
Merge branch 'develop' into fix-so-on-hold
s-aga-r Feb 12, 2023
5faa62c
Merge branch 'develop' into fix-so-on-hold
s-aga-r Feb 14, 2023
4473107
Merge branch 'develop' into fix-so-on-hold
s-aga-r Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions erpnext/stock/stock_balance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ def get_reserved_qty(item_code, warehouse):
and parenttype='Sales Order'
and item_code != parent_item
and exists (select * from `tabSales Order` so
where name = dnpi_in.parent and docstatus = 1 and status != 'Closed')
where name = dnpi_in.parent and docstatus = 1 and status not in ('On Hold', 'Closed'))
) dnpi)
union
(select stock_qty as dnpi_qty, qty as so_item_qty,
Expand All @@ -131,7 +131,7 @@ def get_reserved_qty(item_code, warehouse):
and (so_item.delivered_by_supplier is null or so_item.delivered_by_supplier = 0)
and exists(select * from `tabSales Order` so
where so.name = so_item.parent and so.docstatus = 1
and so.status != 'Closed'))
and so.status not in ('On Hold', 'Closed')))
) tab
where
so_item_qty >= so_item_delivered_qty
Expand Down