Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update reserved_qty when Sales Order marked as Hold #34018

Merged
merged 4 commits into from
Feb 14, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Feb 12, 2023

Source / Ref: ISS-22-23-05186

Steps to replicate:

  1. Create a Sales Order (reserved_qty updated in Bin for the selected Item and Warehouse combination).

    image
    image

  2. Mark the Sales Order as Hold using the Status > Hold button (reserved_qty didn't get updated).

    image
    image

Problem: The reserved_qty should be updated if the Sales Order is marked as Hold. In case Auto re-order is configured in Item Master the system will create Material Request.

Example: The Item ITEM 03 has Actual Qty = 1 and Reserved Qty = 1 i.e., the Projected Qty will be (Actual Qty) 1 - (Reserved Qty) 1 = 0. The Auto re-order is configured for ITEM 03 with Re-order Level as 1. The Auto re-order works based on Projected Qty if the Projected Qty is less than the Re-order Level then a Material Request will be created by the system.

image
image
image

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Feb 12, 2023
@s-aga-r s-aga-r changed the title fix: reset reserved_qty for On Hold Sales Order fix: update reserved_qty when Sales Order marked as Hold Feb 12, 2023
@s-aga-r s-aga-r marked this pull request as ready for review February 12, 2023 10:00
@s-aga-r s-aga-r merged commit 75d9dbc into frappe:develop Feb 14, 2023
@s-aga-r s-aga-r added bug and removed stock needs-tests This PR needs automated unit-tests. backport version-13-hotfix backport version-14-hotfix backport to version 14 labels Feb 14, 2023
s-aga-r added a commit that referenced this pull request Feb 14, 2023
…-34018

fix: update `reserved_qty` when `Sales Order` marked as `Hold` (backport #34018)
s-aga-r added a commit that referenced this pull request Feb 14, 2023
…-34018

fix: update `reserved_qty` when `Sales Order` marked as `Hold` (backport #34018)
@s-aga-r s-aga-r deleted the fix-so-on-hold branch April 15, 2023 10:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant