Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: install fixtures #33964

Merged
merged 3 commits into from
Feb 11, 2023
Merged

refactor: install fixtures #33964

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b48dcd
refactor: install fixtures
barredterra Feb 5, 2023
ad3f56d
style: disable semgrep for install_defaults signature
barredterra Feb 6, 2023
1bb4fe1
Merge branch 'develop' into refactor-install-fixtures
barredterra Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions erpnext/setup/setup_wizard/operations/install_fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,16 +335,11 @@ def install(country=None):
make_default_records()
make_records(records)
set_up_address_templates(default_country=country)
set_more_defaults()
update_global_search_doctypes()


def set_more_defaults():
# Do more setup stuff that can be done here with no dependencies
update_selling_defaults()
update_buying_defaults()
add_uom_data()
update_item_variant_settings()
update_global_search_doctypes()


def update_selling_defaults():
Expand Down Expand Up @@ -381,7 +376,7 @@ def add_uom_data():
)
for d in uoms:
if not frappe.db.exists("UOM", _(d.get("uom_name"))):
uom_doc = frappe.get_doc(
frappe.get_doc(
{
"doctype": "UOM",
"uom_name": _(d.get("uom_name")),
Expand All @@ -404,15 +399,15 @@ def add_uom_data():
if not frappe.db.exists(
"UOM Conversion Factor", {"from_uom": _(d.get("from_uom")), "to_uom": _(d.get("to_uom"))}
):
uom_conversion = frappe.get_doc(
frappe.get_doc(
{
"doctype": "UOM Conversion Factor",
"category": _(d.get("category")),
"from_uom": _(d.get("from_uom")),
"to_uom": _(d.get("to_uom")),
"value": d.get("value"),
}
).insert(ignore_permissions=True)
).db_insert()


def add_market_segments():
Expand Down Expand Up @@ -468,7 +463,7 @@ def install_company(args):
make_records(records)


def install_defaults(args=None):
def install_defaults(args=None): # nosemgrep
records = [
# Price Lists
{
Expand All @@ -493,7 +488,7 @@ def install_defaults(args=None):

# enable default currency
frappe.db.set_value("Currency", args.get("currency"), "enabled", 1)
frappe.db.set_value("Stock Settings", None, "email_footer_address", args.get("company_name"))
frappe.db.set_single_value("Stock Settings", "email_footer_address", args.get("company_name"))

set_global_defaults(args)
update_stock_settings()
Expand Down