Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: install fixtures #33964

Merged
merged 3 commits into from
Feb 11, 2023
Merged

refactor: install fixtures #33964

merged 3 commits into from
Feb 11, 2023

Conversation

barredterra
Copy link
Collaborator

  • remove unnecessary function set_more_defaults
  • remove unused variables uom_doc, uom_conversion
  • use db_insert() for creating UOM Conversion Factor to be consistent with creating OUM
  • move from set_value (deprecated for singles) to supported set_single_value

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 5, 2023
@codecov
Copy link

codecov bot commented Feb 5, 2023 •
edited
Loading

Codecov Report

Merging #33964 (1bb4fe1) into develop (9d8502f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #33964      +/-   ##
===========================================
- Coverage    63.89%   63.88%   -0.01%     
===========================================
  Files          818      818              
  Lines        59286    59284       -2     
===========================================
- Hits         37878    37876       -2     
  Misses       21408    21408
Impacted Files Coverage Δ
.../setup/setup_wizard/operations/install_fixtures.py 90.98% <100.00%> (-0.15%) ⬇️

@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Feb 6, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Feb 11, 2023
@deepeshgarg007 deepeshgarg007 merged commit 201573a into frappe:develop Feb 11, 2023
@mergify mergify bot mentioned this pull request Feb 11, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 11, 2023
@barredterra @mergify
refactor: install fixtures (#33964)
5b7420a 
* refactor: install fixtures

* style: disable semgrep for install_defaults signature

(cherry picked from commit 201573a)
@barredterra barredterra deleted the refactor-install-fixtures branch February 11, 2023 10:48
deepeshgarg007 pushed a commit that referenced this pull request Feb 11, 2023
@mergify @barredterra
refactor: install fixtures (#33964)
dd31bd5 
refactor: install fixtures (#33964)

* refactor: install fixtures

* style: disable semgrep for install_defaults signature

(cherry picked from commit 201573a)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
@commit-lint commit-lint bot mentioned this pull request Mar 17, 2023
Merged
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barredterra @deepeshgarg007