Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't use get_list & get_all interchangeably #33916

Merged
merged 2 commits into from
Feb 1, 2023
Merged

fix: Don't use get_list & get_all interchangeably #33916

merged 2 commits into from
Feb 1, 2023

Conversation

gavindsouza
Copy link
Collaborator

@gavindsouza gavindsouza commented Feb 1, 2023 •
edited
Loading

Changes

  • Remove DatabaseQuery permission checks on aggregated "`tabPurchase Receipt Item`.qty" value
  • Remove DatabaseQuery permission checks in get_returned_qty_map_for_row query

For frappe/frappe#19533

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Feb 1, 2023
@gavindsouza gavindsouza removed the needs-tests This PR needs automated unit-tests. label Feb 1, 2023
@gavindsouza
Copy link
Collaborator Author

gavindsouza commented Feb 1, 2023 •
edited
Loading

CI with Frappe permlevel-apis branch:

3518d4b: https://github.com/gavindsouza/erpnext/actions/runs/4062152116/attempts/2
940ad6e: https://github.com/gavindsouza/erpnext/actions/runs/4062604913

All* passing on develop and permlevel-apis branches:

image
image

* - All except the 3 failing tests on latest develop and other branches

@gavindsouza gavindsouza marked this pull request as ready for review February 1, 2023 09:27
@surajshetty3416 surajshetty3416 merged commit ffeda0c into frappe:develop Feb 1, 2023
This was referenced Mar 9, 2023
Merged
Merged
@gavindsouza gavindsouza changed the title refactor: Query changes due to upcoming DatabaseQuery changes fix: Don't use get_list & get_all interchangeably Mar 9, 2023
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marination marination marination approved these changes

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavindsouza @marination @surajshetty3416 @deepeshgarg007