fix: manual depr entry not updating asset value [v13] #33890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [13.45.0](v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](939a312)) * enable customs in Selling Workpace by default ([#33853](#33853)) ([54c1642](54c1642)) * Fetch commission rate from sales partner ([#33851](#33851)) ([3425a3b](3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](be5edd3)) * item rate not fetching ([bb56415](bb56415)) * manual depr entry not updating asset value [v13] ([#33890](#33890)) ([f5efb20](f5efb20)) * use correct filter name in `item_query` (backport [#33814](#33814)) ([#33817](#33817)) ([b38ad66](b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](0ff5099)) * Timeout while doing payment reconciliation (v13) ([#33818](#33818)) ([4bf3e31](4bf3e31))
|
🎉 This PR is included in version 13.45.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
fix: asset value for manual depr entries
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
# [13.45.0](frappe/erpnext@v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](frappe@939a312)) * enable customs in Selling Workpace by default ([frappe#33853](frappe#33853)) ([54c1642](frappe@54c1642)) * Fetch commission rate from sales partner ([frappe#33851](frappe#33851)) ([3425a3b](frappe@3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](frappe@be5edd3)) * item rate not fetching ([bb56415](frappe@bb56415)) * manual depr entry not updating asset value [v13] ([frappe#33890](frappe#33890)) ([f5efb20](frappe@f5efb20)) * use correct filter name in `item_query` (backport [frappe#33814](frappe#33814)) ([frappe#33817](frappe#33817)) ([b38ad66](frappe@b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](frappe@b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](frappe@0ff5099)) * Timeout while doing payment reconciliation (v13) ([frappe#33818](frappe#33818)) ([4bf3e31](frappe@4bf3e31))
BevanTony1
pushed a commit
to BevanTony1/eso-erpnext
that referenced
this pull request
Mar 23, 2023
# [13.45.0](frappe/erpnext@v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](frappe@939a312)) * enable customs in Selling Workpace by default ([frappe#33853](frappe#33853)) ([54c1642](frappe@54c1642)) * Fetch commission rate from sales partner ([frappe#33851](frappe#33851)) ([3425a3b](frappe@3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](frappe@be5edd3)) * item rate not fetching ([bb56415](frappe@bb56415)) * manual depr entry not updating asset value [v13] ([frappe#33890](frappe#33890)) ([f5efb20](frappe@f5efb20)) * use correct filter name in `item_query` (backport [frappe#33814](frappe#33814)) ([frappe#33817](frappe#33817)) ([b38ad66](frappe@b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](frappe@b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](frappe@0ff5099)) * Timeout while doing payment reconciliation (v13) ([frappe#33818](frappe#33818)) ([4bf3e31](frappe@4bf3e31))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Depreciation Entryoption in theManagedropdown of assets withcalculate_depreciationnot checked) are submitted, the value of the asset isn't updated, so fixed that.TypeError: unsupported operand type(s) for +=: 'int' and 'NoneType'error, so fixed it.AttributeError: 'list' object has no attribute 'strip'error because db.get_value doesn't support list based and ("is", "set")-style filters on v13, so fixed it.