-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable customs in Selling Workpace by default #33853
Merged
deepeshgarg007
merged 4 commits into
frappe:version-13-hotfix
from
FHenry:version-13_fix_workspace_hide_custom
Jan 31, 2023
Merged
fix: enable customs in Selling Workpace by default #33853
deepeshgarg007
merged 4 commits into
frappe:version-13-hotfix
from
FHenry:version-13_fix_workspace_hide_custom
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into version-13_fix_workspace_hide_custom
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [13.45.0](v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](939a312)) * enable customs in Selling Workpace by default ([#33853](#33853)) ([54c1642](54c1642)) * Fetch commission rate from sales partner ([#33851](#33851)) ([3425a3b](3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](be5edd3)) * item rate not fetching ([bb56415](bb56415)) * manual depr entry not updating asset value [v13] ([#33890](#33890)) ([f5efb20](f5efb20)) * use correct filter name in `item_query` (backport [#33814](#33814)) ([#33817](#33817)) ([b38ad66](b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](0ff5099)) * Timeout while doing payment reconciliation (v13) ([#33818](#33818)) ([4bf3e31](4bf3e31))
🎉 This PR is included in version 13.45.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
* fix: enable customs in Selling Workpace by default * fix: enable customs in Selling Workpace by default
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
# [13.45.0](frappe/erpnext@v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](frappe@939a312)) * enable customs in Selling Workpace by default ([frappe#33853](frappe#33853)) ([54c1642](frappe@54c1642)) * Fetch commission rate from sales partner ([frappe#33851](frappe#33851)) ([3425a3b](frappe@3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](frappe@be5edd3)) * item rate not fetching ([bb56415](frappe@bb56415)) * manual depr entry not updating asset value [v13] ([frappe#33890](frappe#33890)) ([f5efb20](frappe@f5efb20)) * use correct filter name in `item_query` (backport [frappe#33814](frappe#33814)) ([frappe#33817](frappe#33817)) ([b38ad66](frappe@b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](frappe@b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](frappe@0ff5099)) * Timeout while doing payment reconciliation (v13) ([frappe#33818](frappe#33818)) ([4bf3e31](frappe@4bf3e31))
BevanTony1
pushed a commit
to BevanTony1/eso-erpnext
that referenced
this pull request
Mar 23, 2023
# [13.45.0](frappe/erpnext@v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](frappe@939a312)) * enable customs in Selling Workpace by default ([frappe#33853](frappe#33853)) ([54c1642](frappe@54c1642)) * Fetch commission rate from sales partner ([frappe#33851](frappe#33851)) ([3425a3b](frappe@3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](frappe@be5edd3)) * item rate not fetching ([bb56415](frappe@bb56415)) * manual depr entry not updating asset value [v13] ([frappe#33890](frappe#33890)) ([f5efb20](frappe@f5efb20)) * use correct filter name in `item_query` (backport [frappe#33814](frappe#33814)) ([frappe#33817](frappe#33817)) ([b38ad66](frappe@b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](frappe@b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](frappe@0ff5099)) * Timeout while doing payment reconciliation (v13) ([frappe#33818](frappe#33818)) ([4bf3e31](frappe@4bf3e31))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like in all other version (version-14 and develop), and like all other default Workspace, there is no reason the hide custom doctype and custom report by default in this workspace
review from #33822