fix: Fetch commission rate from sales partner #33851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33851 +/- ##
===========================================
- Coverage 64.19% 63.84% -0.35%
===========================================
Files 819 818 -1
Lines 59200 59140 -60
===========================================
- Hits 38002 37760 -242
- Misses 21198 21380 +182
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
(cherry picked from commit b3dc22d)
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
(cherry picked from commit b3dc22d) # Conflicts: # erpnext/accounts/doctype/sales_invoice/sales_invoice.json
deepeshgarg007
pushed a commit
that referenced
this pull request
Jan 31, 2023
fix: Fetch commission rate from sales partner (#33851)
deepeshgarg007
pushed a commit
that referenced
this pull request
Jan 31, 2023
* fix: Fetch commission rate from sales partner (#33851)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [13.45.0](v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](939a312)) * enable customs in Selling Workpace by default ([#33853](#33853)) ([54c1642](54c1642)) * Fetch commission rate from sales partner ([#33851](#33851)) ([3425a3b](3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](be5edd3)) * item rate not fetching ([bb56415](bb56415)) * manual depr entry not updating asset value [v13] ([#33890](#33890)) ([f5efb20](f5efb20)) * use correct filter name in `item_query` (backport [#33814](#33814)) ([#33817](#33817)) ([b38ad66](b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](0ff5099)) * Timeout while doing payment reconciliation (v13) ([#33818](#33818)) ([4bf3e31](4bf3e31))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 31, 2023
# [14.15.0](v14.14.0...v14.15.0) (2023-01-31) ### Bug Fixes * Amount validation in Payment Request against Purchase Order ([#33855](#33855)) ([5605f1e](5605f1e)) * Currency symbol for tax withholding net total field ([#33850](#33850)) ([f54e862](f54e862)) * disfuctional cost center filter on Journal Entries ([#33815](#33815)) ([58c3e16](58c3e16)) * disposal_was_made_on_original_schedule_date ([4586806](4586806)) * double salutation on quotation print ([#33834](#33834)) ([0fcf364](0fcf364)) * Fetch commission rate from sales partner ([#33851](#33851)) ([868c8d6](868c8d6)) * **gp:** fetch buying amount from dn related to so ([f5bde9c](f5bde9c)) * GST Category validation broken for pos unregistered customer who dont have address. ([#33800](#33800)) ([f124dd3](f124dd3)) * Ignore linked JE on JE cancellation ([#33852](#33852)) ([a0e1ee0](a0e1ee0)) * item rate not fetching ([b98d351](b98d351)) * Lead to customer creation ([#33859](#33859)) ([44692e9](44692e9)) * manual depr entry not updating asset value [v14] ([#33788](#33788)) ([f487eae](f487eae)) * **patch:** validation error on cost center allocation migration ([#33835](#33835)) ([5d4967c](5d4967c)) * use correct filter name in `item_query` (backport [#33814](#33814)) ([#33816](#33816)) ([f7eabca](f7eabca)) ### Features * **gp:** test for inv and dn related via so ([7a793ea](7a793ea)) ### Performance Improvements * show update items dialog ([ac2ebfb](ac2ebfb))
developsessions
pushed a commit
to developsessions/erpnext
that referenced
this pull request
Feb 1, 2023
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
* fix: Fetch commission rate from sales partner (frappe#33851)
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
# [13.45.0](frappe/erpnext@v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](frappe@939a312)) * enable customs in Selling Workpace by default ([frappe#33853](frappe#33853)) ([54c1642](frappe@54c1642)) * Fetch commission rate from sales partner ([frappe#33851](frappe#33851)) ([3425a3b](frappe@3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](frappe@be5edd3)) * item rate not fetching ([bb56415](frappe@bb56415)) * manual depr entry not updating asset value [v13] ([frappe#33890](frappe#33890)) ([f5efb20](frappe@f5efb20)) * use correct filter name in `item_query` (backport [frappe#33814](frappe#33814)) ([frappe#33817](frappe#33817)) ([b38ad66](frappe@b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](frappe@b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](frappe@0ff5099)) * Timeout while doing payment reconciliation (v13) ([frappe#33818](frappe#33818)) ([4bf3e31](frappe@4bf3e31))
Closed
BevanTony1
pushed a commit
to BevanTony1/eso-erpnext
that referenced
this pull request
Mar 23, 2023
# [13.45.0](frappe/erpnext@v13.44.0...v13.45.0) (2023-01-31) ### Bug Fixes * disposal_was_made_on_original_schedule_date ([939a312](frappe@939a312)) * enable customs in Selling Workpace by default ([frappe#33853](frappe#33853)) ([54c1642](frappe@54c1642)) * Fetch commission rate from sales partner ([frappe#33851](frappe#33851)) ([3425a3b](frappe@3425a3b)) * **gp:** fetch buying amount from dn related to so ([be5edd3](frappe@be5edd3)) * item rate not fetching ([bb56415](frappe@bb56415)) * manual depr entry not updating asset value [v13] ([frappe#33890](frappe#33890)) ([f5efb20](frappe@f5efb20)) * use correct filter name in `item_query` (backport [frappe#33814](frappe#33814)) ([frappe#33817](frappe#33817)) ([b38ad66](frappe@b38ad66)) ### Features * **gp:** test for inv and dn related via so ([b72a35a](frappe@b72a35a)) ### Performance Improvements * show update items dialog ([0ff5099](frappe@0ff5099)) * Timeout while doing payment reconciliation (v13) ([frappe#33818](frappe#33818)) ([4bf3e31](frappe@4bf3e31))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sales Partner has a commission field that doesn't get fetched in the Sales Invoice right now and the user has to add them manually.
Added a fetch from condition to fetch the commission rate from the Sales Partner