Removed an unnecessary check in code which always evaluates to true

[openrefactory]

In file: deferred_revenue_and_expense.py, method: generate_report_data, a logical expression uses the identity operator. A new object is created inside the identity check operation and then used for matching identity. Since this is a distinct, new object, it will not have identity an match with anything else. As a result, the identity check will have a logical short circuit. Moreover in line 378, we already create an entry inside a list. So, the check for emptiness is unnecessary. Currently, the test expression in line 381 is passing all the time.

We removed that unnecessary test expression.

[codecov]

Codecov Report

Merging #33710 (f3a1ae7) into develop (6b31c27) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head f3a1ae7 differs from pull request most recent head 49aed7f. Consider uploading reports for the commit 49aed7f to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33710   +/-   ##
========================================
  Coverage    64.14%   64.14%           
========================================
  Files          819      819           
  Lines        59160    59159    -1     
========================================
  Hits         37946    37946           
+ Misses       21214    21213    -1     

Impacted Files	Coverage Δ
...evenue_and_expense/deferred_revenue_and_expense.py	61.61% <0.00%> (+0.30%)	⬆️

[ruthra-kumar]

@Mergifyio backport version-14-hotfix version-13-hotfix

[mergify]

backport version-14-hotfix version-13-hotfix

✅ Backports have been created

• #33763 Removed an unnecessary check in code which always evaluates to true (backport #33710) has been created for branch version-14-hotfix
• #33764 Removed an unnecessary check in code which always evaluates to true (backport #33710) has been created for branch version-13-hotfix