fix: Sales Order Connections Tabs do not show linked Material Request or "+" button (intoduce by #33304)

[FHenry]

ERPNext develop, versoin-14, version-13

How to reproduce :
Create a Sales order
Create a Material request from the sales order (use create blue button as "+" is missing) => Go to Connections tabs => Go back to originated Sales Order
Check Sales Order Connections Tab, the materials Request is not here.

Before PR:

Before.mp4

After PR:

After.mp4

Note To Reviewer:

• I don't know why @s-aga-r have (or I have) different result, but I test from fresh install without any custom app or customization in version-13, version-14 and develop, and this PR broke exactly what it should to fix
• Linters error is not related with this change.

[FHenry]

When Sales Order is displayed
There is the Frappe API Rest Call
/api/method/frappe.desk.notifications.get_open_count
 
doctype | Sales Order
name | SAL-ORD-2023-00001
items | ["Sales Invoice","Pick List","Delivery Note","Maintenance Visit","Material Request","Purchase Order","Project","Work Order","Quotation","Auto Repeat","Payment Entry","Payment Request","Journal Entry"]

URI param "items" already include Material Request, The is no need to specify it into get_data() on sales_order_dashboard.py.

Either Add "Material Request": ["items", "material_request"], in get_data() on sales_order_dashboard.py is strange, shouldn't it be "Material Request": ["items", "sales_order"], but there is no need as frappe already manage it with "transaction" section ? (manage by frappe/model/meta.py : add_doctype_links()

That can explain why result of API call didn't return at all Material Request count as the field material_request don't exists into Material Request Item

{
	"message": {
		"count": [
			{
				"name": "Sales Invoice",
				"count": 0
			},
			{
				"name": "Pick List",
				"count": 0
			},
			{
				"name": "Delivery Note",
				"count": 0
			},
			{
				"name": "Maintenance Visit",
				"count": 0
			},
			{
				"name": "Purchase Order",
				"count": 0
			},
			{
				"name": "Project",
				"count": 0
			},
			{
				"name": "Work Order",
				"count": 0
			},
			{
				"name": "Auto Repeat",
				"count": 0
			},
			{
				"name": "Payment Entry",
				"count": 0
			},
			{
				"name": "Payment Request",
				"count": 0
			},
			{
				"name": "Journal Entry",
				"count": 0
			}
		]
	}
}

 

[s-aga-r]

@FHenry there are two flows, I have added the fix for the Internal Transfer but it breaks the SO --> MR [MR link in SO]. AFAIK the material_request and material_request_item fields not getting updated when a Material Request gets submitted. To fix this we need to update the same on submit of MR.

[FHenry]

@s-aga-r Ok, Thank you very much for clarification.

So that a similar problem than this issue #27874
We actually can't have more than 1 way to count related linked elements

[s-aga-r]

@s-aga-r Ok, Thank you very much for clarification.

So that a similar problem than this issue #27874 We actually can't have more than 1 way to count related linked elements

@FHenry will be able to see the MR ref(s) in SO if we set the material_request and 'material_request_item' in SO on submission of MR, but I am not sure about the + button will be visible or not. Will try it locally and raise a PR if it works.