revert: Reverting changes done on 33495 #33662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c6af3ff to
ec6ad91
Compare
'ordered_qty' will not be fetched from `tabBin`
ec6ad91 to
4e76794
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33662 +/- ##
===========================================
+ Coverage 64.08% 64.14% +0.06%
===========================================
Files 818 819 +1
Lines 58879 59095 +216
===========================================
+ Hits 37733 37909 +176
- Misses 21146 21186 +40
|
|
@s-aga-r |
|
@Mergifyio backport version-13-hotfix version-14-hotfix |
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2023
'ordered_qty' will not be fetched from `tabBin` (cherry picked from commit be38205)
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 16, 2023
'ordered_qty' will not be fetched from `tabBin` (cherry picked from commit be38205)
ruthra-kumar
added a commit
that referenced
this pull request
Jan 16, 2023
…-33662 revert: Reverting changes done on 33495 (backport #33662)
ruthra-kumar
added a commit
that referenced
this pull request
Jan 16, 2023
…-33662 revert: Reverting changes done on 33495 (backport #33662)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
## [13.43.2](v13.43.1...v13.43.2) (2023-01-17) ### Bug Fixes * allow to create sales order from expired quotation ([#33582](#33582)) ([2f81f15](2f81f15)) * asset value in fixed asset register ([#33608](#33608)) ([42fe63d](42fe63d)) * better comparision of difference value between stock and account ([a450c8d](a450c8d)) * don't check other warehouse ledgers to calculate valuation rate ([66bf107](66bf107)) * handle post depr entries fail and fix asset repair link ([5f7dc8a](5f7dc8a)) * only group similar items in print format if group_same_items is checked in pick list (backport [#33627](#33627)) ([#33631](#33631)) ([7dcf0f0](7dcf0f0)) * Return against internal purchase invoice ([#33635](#33635)) ([eef0f45](eef0f45)) * Sales ORder Connections on Material Request ([97488ae](97488ae)) * Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](a46aa80)) ### Reverts * Reverting changes done on 33495 ([#33662](#33662)) ([0f0a2b1](0f0a2b1))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jan 17, 2023
# [14.13.0](v14.12.1...v14.13.0) (2023-01-17) ### Bug Fixes * allow to create sales order from expired quotation ([#33582](#33582)) ([fe51343](fe51343)) * asset repair link ([bc55f44](bc55f44)) * asset value in fixed asset register ([#33608](#33608)) ([4d2497f](4d2497f)) * attribute error while submitting Repost PLE ([0431a57](0431a57)) * better comparision of difference value between stock and account ([5869fcb](5869fcb)) * minor filter issue while reconciliation tool from bench console ([bddf330](bddf330)) * Missing constructor args in Bank Reco Tool ([#33705](#33705)) ([f88c8c4](f88c8c4)) * only group similar items in print format if group_same_items is checked in pick list (backport [#33627](#33627)) ([#33630](#33630)) ([28f2d35](28f2d35)) * patch item_reposting_for_incorrect_sl_and_gl ([1928195](1928195)) * Rate from LDC in TDS reports (backport [#33699](#33699)) ([#33700](#33700)) ([9fa4c1a](9fa4c1a)) * Return against internal purchase invoice (backport [#33635](#33635)) ([#33658](#33658)) ([35fbd67](35fbd67)) * Sales ORder Connections on Material Request ([8a04031](8a04031)) * Updating SO throws ordered_qty not allowed to change after submission ([f915c18](f915c18)) * zero rm-cost in SCR ([2dfbc6e](2dfbc6e)) ### Features * Date filters on bank reconciliation tool ([#33271](#33271)) ([91b08f1](91b08f1)) * provision to select date type based on filter ([4d65d6f](4d65d6f)) ### Performance Improvements * improve reconciliation speed on JE's with 1000's of rows ([8a498ed](8a498ed)) ### Reverts * Reverting changes done on 33495 ([#33662](#33662)) ([23b9f66](23b9f66))
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
'ordered_qty' will not be fetched from `tabBin` (cherry picked from commit be38205)
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
## [13.43.2](frappe/erpnext@v13.43.1...v13.43.2) (2023-01-17) ### Bug Fixes * allow to create sales order from expired quotation ([frappe#33582](frappe#33582)) ([2f81f15](frappe@2f81f15)) * asset value in fixed asset register ([frappe#33608](frappe#33608)) ([42fe63d](frappe@42fe63d)) * better comparision of difference value between stock and account ([a450c8d](frappe@a450c8d)) * don't check other warehouse ledgers to calculate valuation rate ([66bf107](frappe@66bf107)) * handle post depr entries fail and fix asset repair link ([5f7dc8a](frappe@5f7dc8a)) * only group similar items in print format if group_same_items is checked in pick list (backport [frappe#33627](frappe#33627)) ([frappe#33631](frappe#33631)) ([7dcf0f0](frappe@7dcf0f0)) * Return against internal purchase invoice ([frappe#33635](frappe#33635)) ([eef0f45](frappe@eef0f45)) * Sales ORder Connections on Material Request ([97488ae](frappe@97488ae)) * Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](frappe@a46aa80)) ### Reverts * Reverting changes done on 33495 ([frappe#33662](frappe#33662)) ([0f0a2b1](frappe@0f0a2b1))
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
'ordered_qty' will not be fetched from `tabBin` (cherry picked from commit be38205)
SaiFi0102
pushed a commit
to ServerManagementERPNext/erpnext
that referenced
this pull request
Feb 22, 2023
## [13.43.2](frappe/erpnext@v13.43.1...v13.43.2) (2023-01-17) ### Bug Fixes * allow to create sales order from expired quotation ([frappe#33582](frappe#33582)) ([2f81f15](frappe@2f81f15)) * asset value in fixed asset register ([frappe#33608](frappe#33608)) ([42fe63d](frappe@42fe63d)) * better comparision of difference value between stock and account ([a450c8d](frappe@a450c8d)) * don't check other warehouse ledgers to calculate valuation rate ([66bf107](frappe@66bf107)) * handle post depr entries fail and fix asset repair link ([5f7dc8a](frappe@5f7dc8a)) * only group similar items in print format if group_same_items is checked in pick list (backport [frappe#33627](frappe#33627)) ([frappe#33631](frappe#33631)) ([7dcf0f0](frappe@7dcf0f0)) * Return against internal purchase invoice ([frappe#33635](frappe#33635)) ([eef0f45](frappe@eef0f45)) * Sales ORder Connections on Material Request ([97488ae](frappe@97488ae)) * Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](frappe@a46aa80)) ### Reverts * Reverting changes done on 33495 ([frappe#33662](frappe#33662)) ([0f0a2b1](frappe@0f0a2b1))
Closed
BevanTony1
pushed a commit
to BevanTony1/eso-erpnext
that referenced
this pull request
Mar 23, 2023
## [13.43.2](frappe/erpnext@v13.43.1...v13.43.2) (2023-01-17) ### Bug Fixes * allow to create sales order from expired quotation ([frappe#33582](frappe#33582)) ([2f81f15](frappe@2f81f15)) * asset value in fixed asset register ([frappe#33608](frappe#33608)) ([42fe63d](frappe@42fe63d)) * better comparision of difference value between stock and account ([a450c8d](frappe@a450c8d)) * don't check other warehouse ledgers to calculate valuation rate ([66bf107](frappe@66bf107)) * handle post depr entries fail and fix asset repair link ([5f7dc8a](frappe@5f7dc8a)) * only group similar items in print format if group_same_items is checked in pick list (backport [frappe#33627](frappe#33627)) ([frappe#33631](frappe#33631)) ([7dcf0f0](frappe@7dcf0f0)) * Return against internal purchase invoice ([frappe#33635](frappe#33635)) ([eef0f45](frappe@eef0f45)) * Sales ORder Connections on Material Request ([97488ae](frappe@97488ae)) * Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](frappe@a46aa80)) ### Reverts * Reverting changes done on 33495 ([frappe#33662](frappe#33662)) ([0f0a2b1](frappe@0f0a2b1))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is causing issues in Drop ship creation. #33495 (comment)