Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Return against internal purchase invoice #33635

Merged
merged 1 commit into from
Jan 15, 2023
Merged

fix: Return against internal purchase invoice #33635

merged 1 commit into from
Jan 15, 2023

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Jan 12, 2023 •
edited
Loading

The user is unable to create a debit note (Return) against an internal purchase invoice because of the sales reference missing validation. Return invoices against any purchase invoice should be allowed hence ignoring this validation for such invoices.

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Jan 12, 2023
@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

Merging #33635 (cd77c67) into develop (58ad79d) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #33635      +/-   ##
===========================================
- Coverage    64.18%   64.14%   -0.04%     
===========================================
  Files          819      819              
  Lines        59040    59092      +52     
===========================================
+ Hits         37893    37906      +13     
- Misses       21147    21186      +39
Impacted Files Coverage Δ
erpnext/controllers/accounts_controller.py 85.01% <ø> (ø)
...nk_reconciliation_tool/bank_reconciliation_tool.py 44.12% <0.00%> (-6.62%) ⬇️
...e/subcontracting_receipt/subcontracting_receipt.py 91.80% <0.00%> (-0.34%) ⬇️
...xt/buying/doctype/purchase_order/purchase_order.py 78.27% <0.00%> (ø)
...eport/fixed_asset_register/fixed_asset_register.py 0.00% <0.00%> (ø)
erpnext/stock/doctype/pick_list/pick_list.py 76.59% <0.00%> (+0.05%) ⬆️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.88% <0.00%> (+0.08%) ⬆️
...ype/request_for_quotation/request_for_quotation.py 51.37% <0.00%> (+0.46%) ⬆️
erpnext/controllers/subcontracting_controller.py 87.84% <0.00%> (+0.91%) ⬆️

@deepeshgarg007 deepeshgarg007 merged commit 906ad10 into frappe:develop Jan 15, 2023
@mergify mergify bot mentioned this pull request Jan 15, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 15, 2023
@deepeshgarg007 @mergify
fix: Return against internal purchase invoice (#33635)
c5a86fb 
(cherry picked from commit 906ad10)
@mergify mergify bot mentioned this pull request Jan 15, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jan 15, 2023
@deepeshgarg007 @mergify
fix: Return against internal purchase invoice (#33635)
00ce137 
(cherry picked from commit 906ad10)
deepeshgarg007 added a commit that referenced this pull request Jan 16, 2023
@mergify @deepeshgarg007
fix: Return against internal purchase invoice (#33635)
eef0f45 
fix: Return against internal purchase invoice (#33635)

(cherry picked from commit 906ad10)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
deepeshgarg007 added a commit that referenced this pull request Jan 16, 2023
@mergify @deepeshgarg007
fix: Return against internal purchase invoice (backport #33635) (#33658)
35fbd67 
fix: Return against internal purchase invoice (#33635)

(cherry picked from commit 906ad10)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Jan 17, 2023
@frappe-bot
chore(release): Bumped to Version 13.43.2
550daf2 
## [13.43.2](v13.43.1...v13.43.2) (2023-01-17)

### Bug Fixes

* allow to create sales order from expired quotation ([#33582](#33582)) ([2f81f15](2f81f15))
* asset value in fixed asset register ([#33608](#33608)) ([42fe63d](42fe63d))
* better comparision of difference value between stock and account ([a450c8d](a450c8d))
* don't check other warehouse ledgers to calculate valuation rate ([66bf107](66bf107))
* handle post depr entries fail and fix asset repair link ([5f7dc8a](5f7dc8a))
* only group similar items in print format if group_same_items is checked in pick list (backport [#33627](#33627)) ([#33631](#33631)) ([7dcf0f0](7dcf0f0))
* Return against internal purchase invoice ([#33635](#33635)) ([eef0f45](eef0f45))
* Sales ORder Connections on Material Request ([97488ae](97488ae))
* Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](a46aa80))

### Reverts

* Reverting changes done on 33495 ([#33662](#33662)) ([0f0a2b1](0f0a2b1))
frappe-pr-bot pushed a commit that referenced this pull request Jan 17, 2023
@frappe-bot
chore(release): Bumped to Version 14.13.0
e910c94 
# [14.13.0](v14.12.1...v14.13.0) (2023-01-17)

### Bug Fixes

* allow to create sales order from expired quotation ([#33582](#33582)) ([fe51343](fe51343))
* asset repair link ([bc55f44](bc55f44))
* asset value in fixed asset register ([#33608](#33608)) ([4d2497f](4d2497f))
* attribute error while submitting Repost PLE ([0431a57](0431a57))
* better comparision of difference value between stock and account ([5869fcb](5869fcb))
* minor filter issue while reconciliation tool from bench console ([bddf330](bddf330))
* Missing constructor args in Bank Reco Tool ([#33705](#33705)) ([f88c8c4](f88c8c4))
* only group similar items in print format if group_same_items is checked in pick list (backport [#33627](#33627)) ([#33630](#33630)) ([28f2d35](28f2d35))
* patch item_reposting_for_incorrect_sl_and_gl ([1928195](1928195))
* Rate from LDC in TDS reports (backport [#33699](#33699)) ([#33700](#33700)) ([9fa4c1a](9fa4c1a))
* Return against internal purchase invoice (backport [#33635](#33635)) ([#33658](#33658)) ([35fbd67](35fbd67))
* Sales ORder Connections on Material Request ([8a04031](8a04031))
* Updating SO throws ordered_qty not allowed to change after submission ([f915c18](f915c18))
* zero rm-cost in SCR ([2dfbc6e](2dfbc6e))

### Features

* Date filters on bank reconciliation tool ([#33271](#33271)) ([91b08f1](91b08f1))
* provision to select date type based on filter ([4d65d6f](4d65d6f))

### Performance Improvements

* improve reconciliation speed on JE's with 1000's of rows ([8a498ed](8a498ed))

### Reverts

* Reverting changes done on 33495 ([#33662](#33662)) ([23b9f66](23b9f66))
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
@mergify @deepeshgarg007 @developmentforpeople
fix: Return against internal purchase invoice (frappe#33635)
e7f820a 
fix: Return against internal purchase invoice (frappe#33635)

(cherry picked from commit 906ad10)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
developmentforpeople pushed a commit to Ayuda-Efectiva/erpnext that referenced this pull request Jan 26, 2023
@frappe-bot @developmentforpeople
chore(release): Bumped to Version 13.43.2
cc65328 
## [13.43.2](frappe/erpnext@v13.43.1...v13.43.2) (2023-01-17)

### Bug Fixes

* allow to create sales order from expired quotation ([frappe#33582](frappe#33582)) ([2f81f15](frappe@2f81f15))
* asset value in fixed asset register ([frappe#33608](frappe#33608)) ([42fe63d](frappe@42fe63d))
* better comparision of difference value between stock and account ([a450c8d](frappe@a450c8d))
* don't check other warehouse ledgers to calculate valuation rate ([66bf107](frappe@66bf107))
* handle post depr entries fail and fix asset repair link ([5f7dc8a](frappe@5f7dc8a))
* only group similar items in print format if group_same_items is checked in pick list (backport [frappe#33627](frappe#33627)) ([frappe#33631](frappe#33631)) ([7dcf0f0](frappe@7dcf0f0))
* Return against internal purchase invoice ([frappe#33635](frappe#33635)) ([eef0f45](frappe@eef0f45))
* Sales ORder Connections on Material Request ([97488ae](frappe@97488ae))
* Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](frappe@a46aa80))

### Reverts

* Reverting changes done on 33495 ([frappe#33662](frappe#33662)) ([0f0a2b1](frappe@0f0a2b1))
SaiFi0102 pushed a commit to ServerManagementERPNext/erpnext that referenced this pull request Feb 22, 2023
@mergify @deepeshgarg007 @SaiFi0102
fix: Return against internal purchase invoice (frappe#33635)
c5eeeb1 
fix: Return against internal purchase invoice (frappe#33635)

(cherry picked from commit 906ad10)

Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
SaiFi0102 pushed a commit to ServerManagementERPNext/erpnext that referenced this pull request Feb 22, 2023
@frappe-bot @SaiFi0102
chore(release): Bumped to Version 13.43.2
3597ef0 
## [13.43.2](frappe/erpnext@v13.43.1...v13.43.2) (2023-01-17)

### Bug Fixes

* allow to create sales order from expired quotation ([frappe#33582](frappe#33582)) ([2f81f15](frappe@2f81f15))
* asset value in fixed asset register ([frappe#33608](frappe#33608)) ([42fe63d](frappe@42fe63d))
* better comparision of difference value between stock and account ([a450c8d](frappe@a450c8d))
* don't check other warehouse ledgers to calculate valuation rate ([66bf107](frappe@66bf107))
* handle post depr entries fail and fix asset repair link ([5f7dc8a](frappe@5f7dc8a))
* only group similar items in print format if group_same_items is checked in pick list (backport [frappe#33627](frappe#33627)) ([frappe#33631](frappe#33631)) ([7dcf0f0](frappe@7dcf0f0))
* Return against internal purchase invoice ([frappe#33635](frappe#33635)) ([eef0f45](frappe@eef0f45))
* Sales ORder Connections on Material Request ([97488ae](frappe@97488ae))
* Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](frappe@a46aa80))

### Reverts

* Reverting changes done on 33495 ([frappe#33662](frappe#33662)) ([0f0a2b1](frappe@0f0a2b1))
@barredterra barredterra mentioned this pull request Mar 7, 2023
Closed
BevanTony1 pushed a commit to BevanTony1/eso-erpnext that referenced this pull request Mar 23, 2023
@frappe-bot @BevanTony1
chore(release): Bumped to Version 13.43.2
cf628dd 
## [13.43.2](frappe/erpnext@v13.43.1...v13.43.2) (2023-01-17)

### Bug Fixes

* allow to create sales order from expired quotation ([frappe#33582](frappe#33582)) ([2f81f15](frappe@2f81f15))
* asset value in fixed asset register ([frappe#33608](frappe#33608)) ([42fe63d](frappe@42fe63d))
* better comparision of difference value between stock and account ([a450c8d](frappe@a450c8d))
* don't check other warehouse ledgers to calculate valuation rate ([66bf107](frappe@66bf107))
* handle post depr entries fail and fix asset repair link ([5f7dc8a](frappe@5f7dc8a))
* only group similar items in print format if group_same_items is checked in pick list (backport [frappe#33627](frappe#33627)) ([frappe#33631](frappe#33631)) ([7dcf0f0](frappe@7dcf0f0))
* Return against internal purchase invoice ([frappe#33635](frappe#33635)) ([eef0f45](frappe@eef0f45))
* Sales ORder Connections on Material Request ([97488ae](frappe@97488ae))
* Updating SO throws ordered_qty not allowed to change after submission ([a46aa80](frappe@a46aa80))

### Reverts

* Reverting changes done on 33495 ([frappe#33662](frappe#33662)) ([0f0a2b1](frappe@0f0a2b1))
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
accounts backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deepeshgarg007