Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider child nodes while getting bin details #33444

Merged
merged 6 commits into from
Jan 2, 2023
Merged

fix: consider child nodes while getting bin details #33444

merged 6 commits into from
Jan 2, 2023

Conversation

s-aga-r
Copy link
Contributor

@s-aga-r s-aga-r commented Dec 26, 2022 •
edited
Loading

closes: #28766

Before:

image

After:

image

image

@github-actions github-actions bot added needs-tests This PR needs automated unit-tests. stock labels Dec 26, 2022
@s-aga-r s-aga-r added backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Dec 26, 2022
@s-aga-r s-aga-r force-pushed the fix/github-issue/28766 branch 3 times, most recently from c42466b to 40dde96 Compare December 27, 2022 06:41
@s-aga-r s-aga-r force-pushed the fix/github-issue/28766 branch 4 times, most recently from 86eb1b4 to e717b6d Compare December 27, 2022 07:59
@codecov
Copy link

codecov bot commented Dec 27, 2022 •
edited
Loading

Codecov Report

Merging #33444 (b425c2d) into develop (332f4dc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #33444   +/-   ##
========================================
  Coverage    64.08%   64.09%           
========================================
  Files          818      818           
  Lines        58725    58731    +6     
========================================
+ Hits         37635    37641    +6     
  Misses       21090    21090
Impacted Files Coverage Δ
erpnext/controllers/selling_controller.py 79.56% <100.00%> (ø)
erpnext/stock/get_item_details.py 80.55% <100.00%> (+0.17%) ⬆️

@s-aga-r s-aga-r marked this pull request as ready for review December 27, 2022 10:54
@s-aga-r s-aga-r marked this pull request as draft December 29, 2022 06:25
@s-aga-r s-aga-r force-pushed the fix/github-issue/28766 branch 3 times, most recently from fb5e995 to 7edd0ce Compare December 29, 2022 07:04
@s-aga-r s-aga-r force-pushed the fix/github-issue/28766 branch from 7edd0ce to c716dcc Compare December 29, 2022 08:31
@s-aga-r s-aga-r marked this pull request as ready for review December 29, 2022 13:33
@s-aga-r s-aga-r force-pushed the fix/github-issue/28766 branch from 2d28106 to b425c2d Compare January 2, 2023 05:55
@s-aga-r s-aga-r merged commit a7b011a into frappe:develop Jan 2, 2023
This was referenced Jan 2, 2023
Merged
Merged
s-aga-r added a commit that referenced this pull request Jan 2, 2023
@s-aga-r
Merge pull request #33500 from frappe/mergify/bp/version-14-hotfix/pr…
45d8feb 
…-33444

fix: consider child nodes while getting bin details (backport #33444)
s-aga-r added a commit that referenced this pull request Jan 2, 2023
@s-aga-r
Merge pull request #33501 from frappe/mergify/bp/version-13-hotfix/pr…
985c47f 
…-33444

fix: consider child nodes while getting bin details (backport #33444)
@s-aga-r s-aga-r removed the stock label Jan 24, 2023
@s-aga-r s-aga-r deleted the fix/github-issue/28766 branch April 15, 2023 09:58
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

get_item_details() args.warehouse results in 0 actual_qty when group node is supplied
2 participants
@s-aga-r @rohitwaghchaure