Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow arbitary items in Quotation and Sales Order #33430

Merged
merged 3 commits into from
Dec 30, 2022
Merged

fix: allow arbitary items in Quotation and Sales Order #33430

merged 3 commits into from
Dec 30, 2022

Conversation

SvbZ3r0
Copy link
Contributor

@SvbZ3r0 SvbZ3r0 commented Dec 25, 2022

Arbitary items are required while quoting for an engineered-to-order product. There can't be an item in your database for every request your customer makes.
Allowing arbitary items in Sales Orders follows the same logic. Billing of arbitary items is already allowed.

closes #33429

The Buying side of this issue can possibly be implemented in a similar fashion, but I'm not sure if it'll break anything.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #33430 (d12cd67) into develop (9858d9d) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head d12cd67 differs from pull request most recent head f6db520. Consider uploading reports for the commit f6db520 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33430      +/-   ##
===========================================
+ Coverage    64.07%   64.10%   +0.02%     
===========================================
  Files          818      818              
  Lines        58691    58670      -21     
===========================================
+ Hits         37607    37609       +2     
+ Misses       21084    21061      -23     
Impacted Files Coverage Δ
...customer_ledger_summary/customer_ledger_summary.py 0.00% <0.00%> (ø)
erpnext/selling/doctype/sales_order/sales_order.py 80.28% <0.00%> (+0.07%) ⬆️

@deepeshgarg007 deepeshgarg007 merged commit 48a9cd5 into frappe:develop Dec 30, 2022
@deepeshgarg007 deepeshgarg007 changed the title fix: allow arbitary items in Quotation ans Sales Order fix: allow arbitary items in Quotation and Sales Order Dec 30, 2022
@SvbZ3r0
Copy link
Contributor Author

SvbZ3r0 commented Sep 27, 2023

@deepeshgarg007 can we merge this into v14? I'd forgotten about this since i have a custom app doing this for me

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow arbitary items in Quotations and Sales Orders
2 participants