-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove unnecessary permissions from Appointment and Appointment Booking Settings #33358
Merged
deepeshgarg007
merged 9 commits into
frappe:develop
from
resilient-tech:fix-appointment-booking
Dec 20, 2022
Merged
fix: remove unnecessary permissions from Appointment and Appointment Booking Settings #33358
deepeshgarg007
merged 9 commits into
frappe:develop
from
resilient-tech:fix-appointment-booking
Dec 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #33358 +/- ##
========================================
Coverage 64.00% 64.00%
========================================
Files 818 818
Lines 58630 58632 +2
========================================
+ Hits 37525 37528 +3
+ Misses 21105 21104 -1
|
barredterra
reviewed
Dec 15, 2022
✅ Backports have been created
|
Didn't see the squash label 😅 |
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
# [14.11.0](v14.10.1...v14.11.0) (2022-12-20) ### Bug Fixes * Consolidated financial report ([16ce411](16ce411)) * Cost center filter not working in cash flow report ([ce5065b](ce5065b)) * Cost Center for tax withholding invoices ([728643a](728643a)) * cost_center filter fix for 'Get Outstanding Invoice' in PE ([ff61997](ff61997)) * cost_center filter gives incorrect output ([9b2b281](9b2b281)) * daily scheduler to identify and fix stock transfer entries having incorrect valuation ([deb3efd](deb3efd)) * disabled items showing in the report 'Itemwise Recommended Reorder Level ([493509e](493509e)) * get_serial_nos_for_fg() missing 1 required positional argument: 'args' ([bddb5b8](bddb5b8)) * incorrect type hints (backport [#33381](#33381)) ([#33384](#33384)) ([fa77259](fa77259)) * Payment Request flow fixes from Order to Payment Entry ([a01db8f](a01db8f)) * remove unnecessary permissions from Appointment and Appointment Booking Settings ([#33358](#33358)) ([#33395](#33395)) ([6ef7eaf](6ef7eaf)) * translation for warning on Overbilling/-receipt/-delivery ([ba51d50](ba51d50)) * Unable to import COA through importer ([f8c09ee](f8c09ee)) * unsupported operand type(s) for +: 'int' and 'NoneType' ([7bdfb3d](7bdfb3d)) * unsupported operand type(s) for +=: 'int' and 'NoneType' ([88dc81b](88dc81b)) * use highest precision for exchange rate. ([4a8a84d](4a8a84d)) ### Features * Ignore company related doctype for other apps via hooks ([cd5a2af](cd5a2af)) * improve visibility of default values ([7ff50b9](7ff50b9)) * incoterm named place ([bfe57ac](bfe57ac)) * more control when printing RFQ ([07cda0a](07cda0a))
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport version-13-hotfix
backport version-14-hotfix
backport to version 14
squash
Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.