Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary permissions from Appointment and Appointment Booking Settings #33358

Merged
merged 9 commits into from
Dec 20, 2022

Conversation

DaizyModi
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 15, 2022
@DaizyModi DaizyModi changed the title Fix appointment booking fix: appointment booking Dec 15, 2022
@sagarvora sagarvora changed the title fix: appointment booking fix: remove unnecessary permissions from Appointment and Appointment Booking Settings Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #33358 (9989ccb) into develop (6bb22c7) will increase coverage by 0.00%.
The diff coverage is 33.33%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33358   +/-   ##
========================================
  Coverage    64.00%   64.00%           
========================================
  Files          818      818           
  Lines        58630    58632    +2     
========================================
+ Hits         37525    37528    +3     
+ Misses       21105    21104    -1     
Impacted Files Coverage Δ
erpnext/www/book_appointment/index.py 0.00% <0.00%> (ø)
erpnext/www/book_appointment/verify/index.py 0.00% <ø> (ø)
erpnext/crm/doctype/appointment/appointment.py 76.02% <40.00%> (-0.74%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 81.84% <0.00%> (+0.08%) ⬆️

@sagarvora sagarvora marked this pull request as ready for review December 16, 2022 10:36
@sagarvora sagarvora added squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. backport version-13-hotfix backport version-14-hotfix backport to version 14 and removed needs-tests This PR needs automated unit-tests. labels Dec 16, 2022
@deepeshgarg007 deepeshgarg007 merged commit 9dc1509 into frappe:develop Dec 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 20, 2022

backport version-14-hotfix

✅ Backports have been created

@deepeshgarg007
Copy link
Member

deepeshgarg007 commented Dec 20, 2022

Didn't see the squash label 😅

deepeshgarg007 pushed a commit that referenced this pull request Dec 20, 2022
frappe-pr-bot pushed a commit that referenced this pull request Dec 20, 2022
# [14.11.0](v14.10.1...v14.11.0) (2022-12-20)

### Bug Fixes

* Consolidated financial report ([16ce411](16ce411))
* Cost center filter not working in cash flow report ([ce5065b](ce5065b))
* Cost Center for tax withholding invoices ([728643a](728643a))
* cost_center filter fix for 'Get Outstanding Invoice' in PE ([ff61997](ff61997))
* cost_center filter gives incorrect output ([9b2b281](9b2b281))
* daily scheduler to identify and fix stock transfer entries having incorrect valuation ([deb3efd](deb3efd))
* disabled items showing in the report 'Itemwise Recommended Reorder Level ([493509e](493509e))
* get_serial_nos_for_fg() missing 1 required positional argument: 'args' ([bddb5b8](bddb5b8))
* incorrect type hints (backport [#33381](#33381)) ([#33384](#33384)) ([fa77259](fa77259))
* Payment Request flow fixes from Order to Payment Entry ([a01db8f](a01db8f))
* remove unnecessary permissions from Appointment and Appointment Booking Settings ([#33358](#33358)) ([#33395](#33395)) ([6ef7eaf](6ef7eaf))
* translation for warning on Overbilling/-receipt/-delivery ([ba51d50](ba51d50))
* Unable to import COA through importer ([f8c09ee](f8c09ee))
* unsupported operand type(s) for +: 'int' and 'NoneType' ([7bdfb3d](7bdfb3d))
* unsupported operand type(s) for +=: 'int' and 'NoneType' ([88dc81b](88dc81b))
* use highest precision for exchange rate. ([4a8a84d](4a8a84d))

### Features

* Ignore company related doctype for other apps via hooks ([cd5a2af](cd5a2af))
* improve visibility of default values ([7ff50b9](7ff50b9))
* incoterm named place ([bfe57ac](bfe57ac))
* more control when printing RFQ ([07cda0a](07cda0a))
@sagarvora sagarvora deleted the fix-appointment-booking branch December 28, 2022 08:37
@sagarvora sagarvora restored the fix-appointment-booking branch December 28, 2022 08:37
@sagarvora sagarvora deleted the fix-appointment-booking branch December 28, 2022 08:37
@sagarvora sagarvora restored the fix-appointment-booking branch December 28, 2022 08:38
@sagarvora sagarvora deleted the fix-appointment-booking branch January 2, 2023 14:08
@barredterra barredterra mentioned this pull request Mar 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants