Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: creating internal sales order from PO not fetching Material Request #33268

Closed
wants to merge 3 commits into from

Conversation

vishdha
Copy link
Contributor

@vishdha vishdha commented Dec 8, 2022

fixed: material Request not fetch into sales order for Internal sales order in Purchase order issue fixed

@vishdha
Copy link
Contributor Author

vishdha commented Dec 8, 2022

Merge this into version-14

@s-aga-r s-aga-r changed the title fix: createing internal sale order from PO not fetchiing Material Request issue fixed fix: creating internal sales order from PO not fetching Material Request Dec 8, 2022
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #33268 (ada0757) into develop (7d41f63) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #33268      +/-   ##
===========================================
- Coverage    63.97%   63.97%   -0.01%     
===========================================
  Files          818      818              
  Lines        58644    58644              
===========================================
- Hits         37519    37517       -2     
- Misses       21125    21127       +2     
Impacted Files Coverage Δ
erpnext/stock/stock_ledger.py 89.95% <0.00%> (-0.32%) ⬇️

@vishdha
Copy link
Contributor Author

vishdha commented Dec 12, 2022

@s-aga-r what would require to merge this pull request?

@s-aga-r
Copy link
Contributor

s-aga-r commented Dec 12, 2022

@s-aga-r what would require to merge this pull request?

image

@s-aga-r
Copy link
Contributor

s-aga-r commented Dec 12, 2022

@vishdha, raised a PR to fix the issue.

@s-aga-r s-aga-r closed this Dec 12, 2022
@vishdha
Copy link
Contributor Author

vishdha commented Dec 13, 2022

@s-aga-r can you check this. Some how i face this issue in version 14 https://github.com/frappe/erpnext/blob/develop/erpnext/buying/doctype/purchase_order_item/purchase_order_item.json
When you create Internal Sales order and Save SO this No Copy: 1 cause issue. it not able to fetch Material Request and Material Request Item then full Tracking purpose will ruin for Tracking MR -> PO -> SO->DN->PR.
PR not able to fetch MR details

Kindly Reopen This PR
and Test Internal transfer workflow

  1. Create MR
  2. Create PO from MR
  3. Create SO from PO
  4. Create DN from SO
  5. Create PR from DN

@s-aga-r
Copy link
Contributor

s-aga-r commented Dec 14, 2022

@vishdha working as expected, check the below screenshots for your reference.

MR

image

PO

image

SO

image

DN

image

PR

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants