Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: validate dates in project and task #33217

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

barredterra
Copy link
Collaborator

Depends on frappe/frappe#19079 (develop / version-15 functionality)

Do not backport

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 4, 2022
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #33217 (a2abc87) into develop (d0478ec) will increase coverage by 0.00%.
The diff coverage is 65.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33217   +/-   ##
========================================
  Coverage    64.02%   64.02%           
========================================
  Files          817      817           
  Lines        58577    58576    -1     
========================================
+ Hits         37504    37506    +2     
+ Misses       21073    21070    -3     
Impacted Files Coverage Δ
erpnext/projects/doctype/task/task.py 65.78% <61.11%> (+0.85%) ⬆️
erpnext/projects/doctype/project/project.py 51.62% <100.00%> (+0.31%) ⬆️

@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Dec 6, 2022
@deepeshgarg007 deepeshgarg007 merged commit 63393fa into frappe:develop Dec 6, 2022
@barredterra barredterra deleted the validate-project-dates branch December 6, 2022 10:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants