Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload Currency Exchange Settings in patch #33146

Merged

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Nov 28, 2022

Got an error while migrating a backup that didn't have Currency Exchange Settings

@barredterra barredterra marked this pull request as ready for review November 28, 2022 22:00
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 28, 2022
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Nov 28, 2022
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #33146 (06e094b) into develop (d0478ec) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 06e094b differs from pull request most recent head 5853b80. Consider uploading reports for the commit 5853b80 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33146   +/-   ##
========================================
  Coverage    64.02%   64.03%           
========================================
  Files          817      817           
  Lines        58577    58565   -12     
========================================
- Hits         37504    37502    -2     
+ Misses       21073    21063   -10     
Impacted Files Coverage Δ
...ype/repost_item_valuation/repost_item_valuation.py 69.23% <0.00%> (-1.87%) ⬇️
...ext/manufacturing/doctype/work_order/work_order.py 79.05% <0.00%> (-0.56%) ⬇️
...stock/doctype/material_request/material_request.py 71.47% <0.00%> (-0.20%) ⬇️
erpnext/stock/doctype/stock_entry/stock_entry.py 81.38% <0.00%> (-0.10%) ⬇️
...ctype/stock_reconciliation/stock_reconciliation.py 83.51% <0.00%> (-0.10%) ⬇️
erpnext/controllers/selling_controller.py 79.56% <0.00%> (-0.07%) ⬇️
erpnext/controllers/buying_controller.py 84.65% <0.00%> (-0.04%) ⬇️
.../report/tds_payable_monthly/tds_payable_monthly.py 0.00% <0.00%> (ø)
...tds_computation_summary/tds_computation_summary.py 0.00% <0.00%> (ø)
erpnext/controllers/accounts_controller.py 85.05% <0.00%> (+0.04%) ⬆️
... and 3 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2022

backport version-14-hotfix

✅ Backports have been created

@barredterra barredterra deleted the reload-currency-exchange-settings branch December 6, 2022 12:49
deepeshgarg007 added a commit that referenced this pull request Dec 6, 2022
…-33146

fix: reload Currency Exchange Settings in patch (backport #33146)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants