Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect balance qty #33144

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Nov 28, 2022

Issue

In the stock ledger report, for the Serialized Batch Item (Which has Serial and Batch No) after stock reconciliation the Balance Qty is showing as Zero.
image

After Fix
Screenshot 2022-11-28 at 10 51 58 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 28, 2022
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-incorrect-stock-balance-qty branch from 252c068 to b2105a8 Compare November 28, 2022 17:50
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #33144 (b606a96) into develop (f612606) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33144   +/-   ##
========================================
  Coverage    64.03%   64.03%           
========================================
  Files          817      817           
  Lines        58557    58567   +10     
========================================
+ Hits         37495    37504    +9     
- Misses       21062    21063    +1     
Impacted Files Coverage Δ
...ctype/stock_reconciliation/stock_reconciliation.py 83.61% <100.00%> (+0.09%) ⬆️
...pnext/setup/setup_wizard/operations/taxes_setup.py 90.83% <0.00%> (-6.88%) ⬇️
...cturing/doctype/production_plan/production_plan.py 76.39% <0.00%> (+1.59%) ⬆️

@rohitwaghchaure rohitwaghchaure removed the needs-tests This PR needs automated unit-tests. label Nov 28, 2022
@rohitwaghchaure rohitwaghchaure merged commit a222b0a into frappe:develop Nov 29, 2022
rohitwaghchaure added a commit that referenced this pull request Nov 29, 2022
…-33144

fix: incorrect balance qty (backport #33144)
rohitwaghchaure added a commit that referenced this pull request Nov 29, 2022
…-33144

fix: incorrect balance qty (backport #33144)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant