Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: precision in asset test_scrap_asset #33097

Merged
merged 1 commit into from
Nov 24, 2022
Merged

fix: precision in asset test_scrap_asset #33097

merged 1 commit into from
Nov 24, 2022

Conversation

anandbaburajan
Copy link
Contributor

This is to fix the failing test_scrap_asset here due to incorrect precision.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #33097 (0e72660) into develop (dc8d635) will increase coverage by 0.00%.
The diff coverage is 58.94%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #33097   +/-   ##
========================================
  Coverage    64.03%   64.04%           
========================================
  Files          816      816           
  Lines        58530    58530           
========================================
+ Hits         37482    37483    +1     
+ Misses       21048    21047    -1     
Impacted Files Coverage Δ
...count_balance_timeline/account_balance_timeline.py 0.00% <0.00%> (ø)
...next/accounts/doctype/bank_account/bank_account.py 77.27% <0.00%> (ø)
...octype/bank_transaction/bank_transaction_upload.py 0.00% <0.00%> (ø)
...of_accounts_importer/chart_of_accounts_importer.py 0.00% <0.00%> (ø)
...ange_rate_revaluation/exchange_rate_revaluation.py 48.48% <0.00%> (ø)
...rpnext/accounts/doctype/fiscal_year/fiscal_year.py 57.14% <0.00%> (ø)
...arges_template/sales_taxes_and_charges_template.py 79.41% <0.00%> (ø)
erpnext/accounts/report/cash_flow/cash_flow.py 42.85% <0.00%> (ø)
...cial_statement/consolidated_financial_statement.py 88.58% <ø> (ø)
...customer_ledger_summary/customer_ledger_summary.py 0.00% <0.00%> (ø)
... and 33 more

@deepeshgarg007 deepeshgarg007 merged commit 93f6ea1 into frappe:develop Nov 24, 2022
deepeshgarg007 added a commit that referenced this pull request Nov 24, 2022
…-33097

fix: precision in asset test_scrap_asset (backport #33097)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants