refactor: search queries #33004
Merged
refactor: search queries #33004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ankush
commented
Nov 17, 2022
- guard clauses for readability
- use values or format
- guard clauses for readability - use values or format
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
- guard clauses for readability - use values or format (cherry picked from commit 34e4903)
mergify bot
pushed a commit
that referenced
this pull request
Nov 17, 2022
- guard clauses for readability - use values or format (cherry picked from commit 34e4903) # Conflicts: # erpnext/stock/doctype/material_request/material_request.py # erpnext/stock/doctype/quality_inspection/quality_inspection.py
ankush
added a commit
that referenced
this pull request
Nov 17, 2022
ankush
added a commit
that referenced
this pull request
Nov 17, 2022
* refactor: search queries (#33004) - guard clauses for readability - use values or format (cherry picked from commit 34e4903) # Conflicts: # erpnext/stock/doctype/material_request/material_request.py # erpnext/stock/doctype/quality_inspection/quality_inspection.py * chore: conflicts [skip ci] Co-authored-by: Ankush Menat <ankush@frappe.io>
This was referenced Jan 25, 2023
developmentforpeople
pushed a commit
to Ayuda-Efectiva/erpnext
that referenced
this pull request
Jan 26, 2023
* refactor: search queries (frappe#33004) - guard clauses for readability - use values or format (cherry picked from commit 34e4903) # Conflicts: # erpnext/stock/doctype/material_request/material_request.py # erpnext/stock/doctype/quality_inspection/quality_inspection.py * chore: conflicts [skip ci] Co-authored-by: Ankush Menat <ankush@frappe.io>
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.