Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pos): return: move amount check to pre submit #32979

Closed
wants to merge 1 commit into from

Conversation

ssiyad
Copy link
Contributor

@ssiyad ssiyad commented Nov 15, 2022

closes #31896
ref #31375

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 15, 2022
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #32979 (bb92b39) into develop (c013db6) will not change coverage.
The diff coverage is 83.33%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #32979   +/-   ##
========================================
  Coverage    63.83%   63.83%           
========================================
  Files          819      819           
  Lines        58716    58716           
========================================
  Hits         37481    37481           
  Misses       21235    21235           
Impacted Files Coverage Δ
...rpnext/accounts/doctype/pos_invoice/pos_invoice.py 75.00% <83.33%> (ø)

@ssiyad ssiyad closed this Nov 22, 2022
@ssiyad ssiyad deleted the fix/pos/amount_check_on_return branch November 22, 2022 06:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POS Return not Working
1 participant