fix: use flt instead of cint in get_batch_no
#32788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fad405 to
9fb3fb4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32788 +/- ##
========================================
Coverage 63.81% 63.81%
========================================
Files 817 817
Lines 58515 58515
========================================
Hits 37342 37342
Misses 21173 21173
|
This was referenced Nov 2, 2022
s-aga-r
added a commit
that referenced
this pull request
Nov 2, 2022
…-32788 fix: use `flt` instead of `cint` in `get_batch_no` (backport #32788)
s-aga-r
added a commit
that referenced
this pull request
Nov 2, 2022
…-32788 fix: use `flt` instead of `cint` in `get_batch_no` (backport #32788)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cint(0.4) = 0
flt(0.4) = 0.4
Close: #30339