fix: add missing translation function on report related documents #32713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ernestoruiz89
commented
Oct 26, 2022
…ue_and_expense.py
… match the variance word translated
ernestoruiz89
commented
Oct 26, 2022
| @@ -1009,7 +1009,7 @@ def setup_ageing_columns(self): | |||
| "{range3}-{range4}".format( | |||
| range3=cint(self.filters["range3"]) + 1, range4=self.filters["range4"] | |||
| ), | |||
| "{range4}-{above}".format(range4=cint(self.filters["range4"]) + 1, above=_("Above")), | |||
| _("{range4}-Above").format(range4=cint(self.filters["range4"]) + 1), | |||
There was a problem hiding this comment.
Doing this way are more control to translation, example in spanish i would translate this as "90 días a más" or "mayor a 90 días"
ernestoruiz89
commented
Oct 26, 2022
| @@ -313,11 +313,11 @@ def get_periodic_data(self): | |||
|
|
|||
| def get_period(self, posting_date): | |||
| if self.filters.range == "Weekly": | |||
| period = "Week " + str(posting_date.isocalendar()[1]) + " " + str(posting_date.year) | |||
| period = _("Week {0} {1}").format(str(posting_date.isocalendar()[1]), str(posting_date.year)) | |||
ernestoruiz89
commented
Oct 26, 2022
| @@ -198,11 +198,11 @@ def setup_ageing_columns(filters: Filters, range_columns: List): | |||
| f"0 - {filters['range1']}", | |||
| f"{cint(filters['range1']) + 1} - {cint(filters['range2'])}", | |||
| f"{cint(filters['range2']) + 1} - {cint(filters['range3'])}", | |||
| f"{cint(filters['range3']) + 1} - {_('Above')}", | |||
| _("{0} - Above").format(cint(filters['range3']) + 1), | |||
| ] | |||
There was a problem hiding this comment.
Doing this way are more control to translation, example in spanish i would translate this as "90 días a más" or "mayor a 90 días"
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #32713 +/- ##
===========================================
- Coverage 63.79% 63.79% -0.01%
===========================================
Files 817 817
Lines 58453 58453
===========================================
- Hits 37290 37289 -1
- Misses 21163 21164 +1
|
| @@ -75,7 +75,7 @@ frappe.query_reports["Budget Variance Report"] = { | |||
| "formatter": function (value, row, column, data, default_formatter) { | |||
| value = default_formatter(value, row, column, data); | |||
|
|
|||
| if (column.fieldname.includes('variance')) { | |||
| if (column.fieldname.includes(__("variance"))) { | |||
There was a problem hiding this comment.
@ernestoruiz89 This is not a user-facing string. Its an internal field name, it should not be translated
There was a problem hiding this comment.
If it is not translated it does not work, because the field is translated from python
|
@Mergifyio backport version-14-hotfix |
✅ Backports have been created
|
deepeshgarg007
added a commit
that referenced
this pull request
Nov 3, 2022
…-32713 fix: add missing translation function on report related documents (backport #32713)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.