Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use naming_series in budget #32554

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix: use naming_series in budget #32554

merged 2 commits into from
Oct 11, 2022

Conversation

anandbaburajan
Copy link
Contributor

The autoname way of naming in Budget doesn't allow special characters hence moving to naming_series.

Fixes #32390.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 10, 2022
@anandbaburajan anandbaburajan requested a review from ankush October 10, 2022 17:47
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #32554 (ba75482) into develop (65194ef) will increase coverage by 0.40%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #32554      +/-   ##
===========================================
+ Coverage    63.88%   64.29%   +0.40%     
===========================================
  Files          817      817              
  Lines        58230    58229       -1     
===========================================
+ Hits         37203    37439     +236     
+ Misses       21027    20790     -237     
Impacted Files Coverage Δ
erpnext/accounts/doctype/budget/budget.py 91.80% <100.00%> (-0.05%) ⬇️
...stock/doctype/purchase_receipt/purchase_receipt.py 92.72% <0.00%> (ø)
...ext/manufacturing/doctype/work_order/work_order.py 79.07% <0.00%> (+0.13%) ⬆️
erpnext/stock/get_item_details.py 80.35% <0.00%> (+0.14%) ⬆️
erpnext/stock/doctype/serial_no/serial_no.py 89.22% <0.00%> (+0.23%) ⬆️
erpnext/controllers/buying_controller.py 84.65% <0.00%> (+0.24%) ⬆️
erpnext/projects/doctype/project/project.py 51.30% <0.00%> (+0.32%) ⬆️
...t/accounts/report/general_ledger/general_ledger.py 68.25% <0.00%> (+0.34%) ⬆️
...xt/e_commerce/doctype/website_item/website_item.py 48.34% <0.00%> (+0.41%) ⬆️
erpnext/stock/report/stock_ageing/stock_ageing.py 95.71% <0.00%> (+0.47%) ⬆️
... and 28 more

@deepeshgarg007
Copy link
Member

@Mergifyio backport version-14-hotfix

@deepeshgarg007 deepeshgarg007 merged commit 6a2edab into frappe:develop Oct 11, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2022

backport version-14-hotfix

✅ Backports have been created

deepeshgarg007 added a commit that referenced this pull request Oct 11, 2022
…-32554

fix: use naming_series in budget (backport #32554)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Special Character in Cost Center Name Causing Auto Naming Hit Error in Creating Budget
2 participants